[Refactor] Fix style in example #125616
Closed
[Refactor] Fix style in example #125616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: examples
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
natsuk4ze
changed the title
natsuk4ze
changed the title
natsuk4ze
changed the title
natsuk4ze
changed the title
Contributor
Author
|
@goderbauer It seems to keep getting stuck at "Google testing has started". What should I do? |
…125631) flutter/engine@79237ad...9684135 2023-04-27 [email protected] Roll Fuchsia Mac SDK from Du6g64Nirs3tZVK6i... to Rk2iPE0_H1vjuGV4e... (flutter/engine#41551) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from Du6g64Nirs3t to Rk2iPE0_H1vj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…125634) flutter/engine@9684135...381f714 2023-04-27 [email protected] Roll Dart SDK from 497a81b1af4f to c7160d4ea0b7 (1 revision) (flutter/engine#41550) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes #125619 ### Before  ### After 
…125954) flutter/engine@0407a16...99e5184 2023-05-03 [email protected] Roll Skia from 3c1ecab42cd4 to b58340991480 (1 revision) (flutter/engine#41689) 2023-05-03 [email protected] Roll Skia from 7781dda8104f to 3c1ecab42cd4 (2 revisions) (flutter/engine#41688) 2023-05-03 [email protected] Roll Dart SDK from 7c061d8c9dc0 to 4d084f5b8f91 (1 revision) (flutter/engine#41686) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…125969) flutter/engine@99e5184...bc8f140 2023-05-03 [email protected] Roll Fuchsia Mac SDK from ubfKertFqqUj0WD8I... to WAfNudyWPOGyWSpZD... (flutter/engine#41691) 2023-05-03 [email protected] Roll Skia from b58340991480 to 887e58fff02f (2 revisions) (flutter/engine#41690) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from ubfKertFqqUj to WAfNudyWPOGy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…125972) flutter/engine@bc8f140...b71728b 2023-05-03 [email protected] Roll Dart SDK from 4d084f5b8f91 to 342dff83c38e (2 revisions) (flutter/engine#41692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adding a `printOnFailure` call into the flakey test to help debug the cause for future failures. - Reference issue: #125512
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android slider_perf_android"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20slider_perf_android%22).
This test can be marked as unflaky.
flutter/packages@f163786...407b7da 2023-05-03 [email protected] Update Cirrus to Xcode 14.3 (flutter/packages#3890) 2023-05-03 [email protected] [file_selector] Deprecates `macUTIs` (flutter/packages#3888) 2023-05-03 [email protected] [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889) 2023-05-02 [email protected] Update xcode to 14e222b (flutter/packages#3868) 2023-05-02 [email protected] [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658) 2023-05-02 [email protected] [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834) 2023-05-02 [email protected] [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848) 2023-05-02 [email protected] [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691) 2023-05-02 [email protected] [local_auth_android] Fix Android lint warnings (flutter/packages#3764) 2023-05-02 [email protected] [go_router_builder] Support go_router v7 (flutter/packages#3858) 2023-05-02 [email protected] [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812) 2023-05-02 [email protected] [file_selector] Add MIME type support on macOS (flutter/packages#3862) 2023-05-02 [email protected] Roll Flutter from 828a040 to db6074a (12 revisions) (flutter/packages#3881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…125989) flutter/engine@b71728b...7d70dc8 2023-05-03 [email protected] Roll Dart SDK from 342dff83c38e to 3cfcfb24bc6a (1 revision) (flutter/engine#41698) 2023-05-03 [email protected] [web] Add `dart:js_interop_unsafe` to SDK. (flutter/engine#41591) 2023-05-03 [email protected] Roll Fuchsia Linux SDK from 9T4mGpfsJZO0KPtfp... to n1UnzmslAzt04yRv6... (flutter/engine#41697) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9T4mGpfsJZO0 to n1UnzmslAzt0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds SLSA L1 badge
I'd like to find out the `fontSize` of a `PlaceholderSpan`, and currently there doesn't seem to be a way to do `TextStyle` cascading in the framework: `InlineSpan.visitChildren` traverses the entire `InlineSpan` tree using a preorder traversal, and nodes that don't have "content" will be skipped (https://master-api.flutter.dev/flutter/painting/InlineSpan/visitChildren.html): > Walks this [InlineSpan](https://master-api.flutter.dev/flutter/painting/InlineSpan-class.html) and any descendants in pre-order and calls visitor for each span that has content. which makes it impossible to do `TextStyle` cascading in the framework: - `InlineSpan`s with a non-null `TextStyle` but has no content will be skipped - `visitChildren` doesn't directly expose the hierarchy, it only gives information about the flattened tree. This doesn't look like a breaking change, most internal customers are extending `WidgetSpan` which has a concrete implementation of the new method. Alternatively I could create a fake `ui.ParagraphBuilder` and record the `ui.TextStyle` at the top of the stack when `addPlaceholder` is called. But `ui.TextStyle` properties are not exposed to the framework.
…droid Studio bundled Java version is detected (#125836) This is an attempt to reland #124085. Differences from this attempt and the last: 1. Adds a check for null android studio versions and a test for this case. 2. Wraps the migrate code in a try-catch [per the suggestion here](https://github.com/flutter/flutter/pull/125728/files#r1181747899). Old PR description: This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see #122376. The PR also upgrades older gradle versions being used in integration testing to 7.4. Fixes/related to: #122376 and #123636
Also fixed some comments
…126018) flutter/engine@7d70dc8...a0906bd 2023-05-03 [email protected] [Impeller] Load instead of restore drawing for non-MSAA passes (flutter/engine#41676) 2023-05-03 [email protected] Remove physical model layer (flutter/engine#41593) 2023-05-03 [email protected] Reland: "Determine lifecycle by looking at window focus also" (#41094) (flutter/engine#41702) 2023-05-03 [email protected] Roll Skia from 887e58fff02f to 93c869da03f5 (12 revisions) (flutter/engine#41705) 2023-05-03 [email protected] [web] Improve null safety for color->css (flutter/engine#41699) 2023-05-03 [email protected] [web] Remove unused function parameter (flutter/engine#41700) 2023-05-03 [email protected] Migrate Android Engine Debug to Engine V2. (flutter/engine#41687) 2023-05-03 [email protected] Migrate SkSurface::getBackend* methods to static functions (flutter/engine#41693) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…126027) flutter/engine@a0906bd...85516ec 2023-05-03 [email protected] [macOS] Remove view ID from public (flutter/engine#41712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#125937) Also update the order of args to commands so that testing has less repeated "stuff"
…126032) flutter/engine@85516ec...ee65be7 2023-05-03 [email protected] Add relative path support for malioc_diff. (flutter/engine#41703) 2023-05-03 [email protected] Roll Fuchsia Mac SDK from WAfNudyWPOGyWSpZD... to LCajvqTauUudC-7RW... (flutter/engine#41716) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from WAfNudyWPOGy to LCajvqTauUud If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…126037) flutter/engine@ee65be7...da45a21 2023-05-04 [email protected] Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib (flutter/engine#41720) 2023-05-04 [email protected] [Impeller] Remove the DrawPaint->Clear optimization (flutter/engine#41711) 2023-05-03 [email protected] Roll Dart SDK from 3cfcfb24bc6a to 59787216f670 (2 revisions) (flutter/engine#41718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…s://github.com/negotoyolo/flutter into Fix-style-of-examples-image_list-lib-main.dart
Contributor
Author
|
I rebased the branch to fix the Google test stack, but the commit history was not combined... |
Contributor
Author
|
@goderbauer I fixed it. |
Contributor
Author
|
Since the commit history has become complicated, I will close this one and create a new PR. |
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
May 8, 2023
Replaces #125616 I just fixed "IMAGES" to "images" in examples/image_list. Currently, "PREFER uses the lower case of the constant name ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just fixed "IMAGES" to "images" in examples/image_list.
Currently, "PREFER uses the lower case of the constant name ".
Pre-launch Checklist
///).