Skip to content

fix: moreOrLessEquals does not allow actual to be integers #125599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 27, 2023
Merged

fix: moreOrLessEquals does not allow actual to be integers #125599

auto-submit merged 2 commits into from
Apr 27, 2023

Conversation

@fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Apr 27, 2023 •
edited by ricardoamador
Loading

Close #125600

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 27, 2023
@fzyzcjy fzyzcjy marked this pull request as ready for review April 27, 2023 02:37
jonahwilliams
jonahwilliams approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

werainkhatri
werainkhatri approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow. thanks for fixing this. LGTM.

@werainkhatri werainkhatri added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 27, 2023
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Apr 27, 2023

You are welcome!

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Apr 27, 2023 •
edited
Loading

Btw, tree tip is green + 2 approvals + autosubmit label + google testing passed, but the bot does not merge the PR after half an hour. Shall I file an infra bug?

EDIT: Already posted in https://discord.com/channels/608014603317936148/608021351567065092/1101090518387138560

image
image
image

@ricardoamador ricardoamador added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 27, 2023
@auto-submit auto-submit bot merged commit 37c95a2 into flutter:master Apr 27, 2023
@TahaTesser TahaTesser mentioned this pull request Apr 28, 2023
Merged
8 tasks
@Piinks Piinks mentioned this pull request Apr 28, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
2fc597d 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
a5e2e45 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
a489c2d 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
145e7bd 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
23f366a 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
0e9045e 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
1ad8ab4 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
a4178b4 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
1511d75 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
deee1bb 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
51a80c4 
flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
d94f0de 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
77bcd0b 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
e1779e1 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
66bc5a5 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
3edccd0 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
9c657cf 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
45bb269 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
f71c80d 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
c78b3b7 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
129e807 
flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a2 fix: moreOrLessEquals does not allow actual to be integers (
8970928 
flutter/flutter#125599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werainkhatri werainkhatri werainkhatri approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

moreOrLessEquals does not allow actual to be integers

4 participants

@fzyzcjy @jonahwilliams @werainkhatri @ricardoamador