Add Cupertino icon fonts helper and dependency for default template #12559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szakarias
approved these changes
Oct 16, 2017
|
|
||
| /// Identifiers for the supported Cupertino icons. | ||
| /// | ||
| /// Use with with the [Icon] class to show specific icons. |
| // Manually maintained list | ||
|
|
||
| static const IconData left_chevron = const IconData(0xf3f0, fontFamily: 'packages/cupertino_icons/CupertinoIcons'); | ||
|
|
Contributor
There was a problem hiding this comment.
I think IconData should have a 'package' parameter like TextStyle so that you don't need to write 'packages/...' in the font family name. I can do that and update this list.
Hixie
reviewed
Oct 16, 2017
| # The following line ensures that the Material Icons font is | ||
| # included with your application, so that you can use the icons in | ||
| # the Icons class. | ||
| # the material Icons class. |
Contributor
There was a problem hiding this comment.
please make sure there's a bug on file about moving us to be consistent for both material and cupertino
Contributor
|
This regressed our documentation benchmark by 475%. |
Member
Author
|
ayy.. will fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10334
Font hosted and maintained separately at https://github.com/flutter/cupertino_icons