Skip to content

Add slider_perf_android task to ci.yaml #125540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Apr 27, 2023
Merged

Add slider_perf_android task to ci.yaml #125540

auto-submit merged 3 commits into from
Apr 27, 2023

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 26, 2023

This adds devicelab task slider_perf_android to .ci.yaml, which was added in #125296

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested review from Piinks and yusuf-goog April 26, 2023 07:40
@TahaTesser TahaTesser changed the title Add slider_perf_android task to .ci.yaml Add slider_perf_android task to ci.yaml Apr 26, 2023
Piinks
Piinks approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for thinking of putting these benchmarks in place before the big refactoring!

Piinks
Piinks reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs test owner ship defined in https://github.com/flutter/flutter/blob/master/TESTOWNERS

# Test ownership check failed.
Builders missing owner: [Linux_android slider_perf_android]
Please define ownership in https://github.com/flutter/flutter/blob/master/TESTOWNERS

@TahaTesser
Copy link
Member Author

TahaTesser commented Apr 27, 2023

Looks like this needs test owner ship defined in https://github.com/flutter/flutter/blob/master/TESTOWNERS

# Test ownership check failed.
Builders missing owner: [Linux_android slider_perf_android]
Please define ownership in https://github.com/flutter/flutter/blob/master/TESTOWNERS

Thank you! I'm adding this task for the first time.

@TahaTesser TahaTesser force-pushed the ci_slider_perf_android branch from c8f9024 to 0020a8d Compare April 27, 2023 20:18
@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team autosubmit Merge PR when tree becomes green via auto submit App labels Apr 27, 2023
@auto-submit auto-submit bot merged commit 746cacc into flutter:master Apr 27, 2023
@TahaTesser TahaTesser deleted the ci_slider_perf_android branch April 27, 2023 21:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
d38165c 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
7c8473b 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
1a8f14b 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
276b901 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
e0b3952 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
2d2ad5f 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
37e326d 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
390e80b 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
791c034 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
9a9b5ae 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
f141ef4 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
4999fd6 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
ee9ece8 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
04a51e0 
…125540)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
81efd6d 
…125540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
3b248fe 
…125540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
ec344b0 
…125540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
41dab08 
…125540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
77a71c4 
…125540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
cb49736 
…125540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
3aa984b 
…125540)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
746cacc Add slider_perf_android task to ci.yaml (flutter/flutter#…
30809ca 
…125540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @Piinks