Skip to content

Mark module_test_ios tests unflaky #125498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 27, 2023
Merged

Mark module_test_ios tests unflaky #125498

auto-submit merged 1 commit into from
Apr 27, 2023

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 25, 2023

Dart workaround to prevent the flake has rolled into the framework. Mark the tests unflaky so we can detect if it happens again when a fix for the underlying issue lands.

#125425 (comment)

Reverts #125426

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Apr 25, 2023
@jmagman jmagman requested review from a-siva and keyonghan April 25, 2023 17:19
keyonghan
keyonghan reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we wait for the bot to auto deflake after 50 runs validation, just in case?

@jmagman
Copy link
Member Author

jmagman commented Apr 26, 2023

Could we wait for the bot to auto deflake after 50 runs validation, just in case?

I'd like to know if it starts flaking again if the dart team submits a fix for the underlying issue, but it doesn't work or is incomplete for some reason.

@jmagman jmagman requested a review from vashworth April 27, 2023 16:51
vashworth
vashworth approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Apr 27, 2023

This failed not too long ago due to flutter/engine#41533 and may have caught it in the presubmit of the engine roll.

Let's turn this back on.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 27, 2023
@auto-submit auto-submit bot merged commit 28e1717 into flutter:master Apr 27, 2023
@jmagman jmagman deleted the module-unflaky branch April 27, 2023 18:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
ed3e684
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
beff18f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
ab6defa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
f771426
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
68cbb7a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
5a72e5f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
5342e9e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
6d57692
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
9bf1146
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
3e82836
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
33e0129
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
215d562
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
b3686b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
33dbe82
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
6128d8c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
861a024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
1007d7b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
e763684
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
150df5b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
fbe9180
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
7906947
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
28e1717 Mark module_test_ios tests unflaky (flutter/flutter#125498)
5385072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

@a-siva a-siva Awaiting requested review from a-siva

+1 more reviewer

@keyonghan keyonghan keyonghan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @vashworth @keyonghan