Skip to content

[tool,web] track web-renderer, and Wasm build args in analytics #125336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 21, 2023
Merged

[tool,web] track web-renderer, and Wasm build args in analytics #125336

auto-submit merged 1 commit into from
Apr 21, 2023

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 21, 2023

Addresses part of #125164

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 21, 2023
@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@kevmoo kevmoo force-pushed the i125164_more_web_analytics branch from 59d0e7d to cb2c70c Compare April 21, 2023 21:29
eyebrowsoffire
eyebrowsoffire approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit auto-submit bot merged commit 702f014 into master Apr 21, 2023
@auto-submit auto-submit bot deleted the i125164_more_web_analytics branch April 21, 2023 23:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
dfccb64 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
a827d35 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
cb68209 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
464528d 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
c0e6c6e 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
f570a76 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
9246cbc 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
78c31d6 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
8ee6822 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
2af59b8 
…cs (flutter/flutter#125336)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
c8dcdc8 
…cs (flutter/flutter#125336)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
afd650f 
…cs (flutter/flutter#125336)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
2a9517a 
…cs (flutter/flutter#125336)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
702f014 [tool,web] track web-renderer, and Wasm build args in analyti…
7fd5f81 
…cs (flutter/flutter#125336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo @eyebrowsoffire