Test AGP 8.0 using java 17 #125323

reidbaker · 2023-04-21T18:42:39Z

Update Gradle/AGP version and add namespace plus dependencies.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

reidbaker · 2023-04-21T19:09:57Z

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8783181311295663521/+/u/run_test.dart_for_build_tests_shard_and_subshard_1_3/test_stdout

Caused by: com.android.builder.errors.EvalIssueException: Android Gradle plugin requires Java 17 to run. You are currently using Java 11."

stuartmorgan-g · 2023-04-22T00:50:13Z

packages/integration_test/android/build.gradle


 android {
-    compileSdkVersion 31
+    namespace = 'dev.flutter.integration_test'


I know almost nothing about Groovy, so maybe this is an irrelevant difference, but I've been doing using the syntax namespace 'dev.flutter.integration_test', which is what https://developer.android.com/build/configure-app-module#groovy shows for Groovy.

I see looking around more that https://developer.android.com/build/publish-library/prep-lib-release does the =, but maybe there's a difference in how unsupported/unknown things are handled with one syntax vs. the other?

yeah given that groovy is a dynamic language I wonder if the = is more strict. That seems like a reasonable guess.

Or the issue could be that I used the wrong namespace and the error messages are not helpful :shamecube:

My understanding of groovy is that foo 'bar' is equivalent to foo('bar') (i.e. a method call), while foo = 'bar' is what you would expect it to be.

But (not sure about this part) that they end up equivalent in some places because that foo is just a setter method for a foo property.

See https://stackoverflow.com/questions/22759542/confused-with-the-use-of-assignment-and-brackets (the question is somewhat different but the top answer covers the topic).

…inifest files

flutter-dashboard · 2023-04-25T21:18:09Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

packages/integration_test/android/build.gradle

stuartmorgan-g

LGTM, with one reservation. I'll leave it to your judgement though.

stuartmorgan-g · 2023-04-27T20:42:16Z

packages/integration_test/example/android/app/build.gradle

+    // Conditional for compatibility with AGP <4.2.
+    if (project.android.hasProperty("namespace")) {
+        namespace 'com.example.integration_test_example'
+    }


Apparently I didn't save the comment that was supposed to go with that overall comment:

Could we make just this change in one PR, to make it as safe as possible to cherry-pick, and do the rest in a second PR that we don't cherry-pick? I'm slightly worried that the AGP update here might cause unexpected issues for clients (since IIRC we've hit issues in the past where we thought that wouldn't affect clients and then it did, but maybe I'm misremembering).

This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in #125296

This PR updates the dartdoc version to v6.2.2. Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2 The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers. See dart-lang/dartdoc#3391, dart-lang/dartdoc#3402. This will also be a cherry-pick candidate for 3.1 if it can land in time. - [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].

…dio bundled Java version is detected (#124085) This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see #122376. The PR also upgrades older gradle versions being used in integration testing to 7.4. Fixes/related to: #122376 and #123636

stuartmorgan-g

LGTM modulo the Dart formatting.

...ges/flutter_tools/test/integration.shard/android_plugin_compilesdkversion_mismatch_test.dart

…-only

…mismatch_test.dart

flutter/flutter@4ed1c92...8c5a1ea 2023-05-08 [email protected] tool/web: tiniest tweak to wasm help content (flutter/flutter#126284) 2023-05-08 [email protected] Roll Flutter Engine from d9184ce4ffa0 to 8d3a8162b3ab (7 revisions) (flutter/flutter#126288) 2023-05-08 [email protected] Fix that `flutter test` does not understand `concurrency` (flutter/flutter#125942) 2023-05-08 [email protected] Fix that `flutter test` does not understand `concurrency` (flutter/flutter#125942) 2023-05-08 [email protected] Improve the format in `asset_bundle.dart` (flutter/flutter#126229) 2023-05-08 [email protected] Tiny cleanup for Navigator code (without introducing dependency) (flutter/flutter#125628) 2023-05-08 [email protected] [Refactor] Fix style in example (flutter/flutter#126191) 2023-05-08 [email protected] Roll Flutter Engine from a8e9ac63fd95 to d9184ce4ffa0 (2 revisions) (flutter/flutter#126279) 2023-05-08 [email protected] [Tool] Output help on 'flutter pub' (flutter/flutter#126211) 2023-05-08 [email protected] Always use `--concurrency=1` for web tests. (flutter/flutter#126179) 2023-05-08 [email protected] Add `--verbose` flags for flakey tests (flutter/flutter#126162) 2023-05-08 [email protected] Roll Packages from a0f8fd8 to 4800d65 (2 revisions) (flutter/flutter#126269) 2023-05-08 [email protected] Test AGP 8.0 using java 17 (flutter/flutter#125323) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Apr 21, 2023

reidbaker requested a review from stuartmorgan-g April 21, 2023 18:43

reidbaker added 3 commits April 21, 2023 15:30

remove more changes to only update namespace

24415ad

Update AGP in example to minimum requried to support namespace

c15ced8

Merge branch 'master' into i125181-namespace-only

b656ca1

reidbaker mentioned this pull request Apr 21, 2023

[integration_test] add support for agp8.0 #125310

Closed

8 tasks

reidbaker added 3 commits April 21, 2023 16:21

revert all example changes

863a876

revert all example changes attempt 2

b4d3f32

explicitly set exported on main activity

6ac8521

stuartmorgan-g reviewed Apr 22, 2023

View reviewed changes

reidbaker added 4 commits April 24, 2023 14:47

remove = from namespace set

069ac13

Merge branch 'master' into i125181-namespace-only

6979d66

Update gradle and agp and run updater while keeping package set in ma…

5d5a5d1

…inifest files

Merge branch 'master' into i125181-namespace-only

71a23b1

reidbaker marked this pull request as ready for review April 25, 2023 21:17

reidbaker requested review from camsim99 and gmackall April 25, 2023 21:17

stuartmorgan-g requested changes Apr 25, 2023

View reviewed changes

packages/integration_test/android/build.gradle Show resolved Hide resolved

reidbaker added 3 commits April 26, 2023 15:36

add namespace back

4c04346

Conditional namespace

c735cd4

Merge branch 'master' into i125181-namespace-only

c17e652

stuartmorgan-g approved these changes Apr 27, 2023

View reviewed changes

stuartmorgan-g reviewed Apr 27, 2023

View reviewed changes

reidbaker changed the title ~~Minimal update to support agp 8~~ Support AGP 8.0 and update gradle Apr 27, 2023

TahaTesser and others added 3 commits April 28, 2023 12:49

Add slider_perf_android task to ci.yaml (#125540)

e22a30d

This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in #125296

reidbaker requested a review from stuartmorgan-g April 28, 2023 17:21

reidbaker marked this pull request as draft April 28, 2023 17:21

reidbaker added 4 commits April 28, 2023 13:30

Update recipes that run integration test to use java 17

ee555a2

Update recipes that run integration test to use java 17

4439f87

Make test more flexible to changing code error messages

63728b9

Merge branch 'master' into i125181-namespace-only

accf1d6

reidbaker changed the title ~~Support AGP 8.0 and update gradle~~ Test AGP 8.0 using java 17 May 1, 2023

Merge branch 'master' into i125181-namespace-only

3e01bf7

reidbaker marked this pull request as ready for review May 1, 2023 22:56

stuartmorgan-g approved these changes May 3, 2023

View reviewed changes

...ges/flutter_tools/test/integration.shard/android_plugin_compilesdkversion_mismatch_test.dart Outdated Show resolved Hide resolved

reidbaker added 4 commits May 5, 2023 10:52

Merge remote-tracking branch 'upstream/master' into i125181-namespace…

1bfbbfc

…-only

Revert dart format style changes to android_plugin_compilesdkversion_…

6830ec3

…mismatch_test.dart

Update platform_interaction to build with java 17

2b69388

Update hybrid_android_views to build with java 17 buy updating agp

5a30100

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023

auto-submit bot merged commit 0fdddd6 into flutter:master May 8, 2023

engine-flutter-autoroll mentioned this pull request May 9, 2023

Roll Flutter from 4ed1c9230310 to 8c5a1ea7281a (13 revisions) flutter/packages#3949

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2023

0fdddd6 Test AGP 8.0 using java 17 (flutter/flutter#125323)

b51d037

gmackall mentioned this pull request May 11, 2023

Many Android build tests flaking on reading debug keystore #126557

Closed

loic-sharma mentioned this pull request Jun 23, 2023

Add an example showing how to use textures #122779

Merged

gmackall mentioned this pull request Jul 5, 2023

Define anchors for build_tests dependencies #130037

Closed

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

0fdddd6 Test AGP 8.0 using java 17 (flutter/flutter#125323)

82ba754

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

0fdddd6 Test AGP 8.0 using java 17 (flutter/flutter#125323)

a8b656d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

0fdddd6 Test AGP 8.0 using java 17 (flutter/flutter#125323)

2e98ed3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

0fdddd6 Test AGP 8.0 using java 17 (flutter/flutter#125323)

a7f1220

gmackall mentioned this pull request Sep 11, 2023

New test FlutterDeviceScreenshotTest is failing on monorepo CI #134419

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Test AGP 8.0 using java 17 #125323

Test AGP 8.0 using java 17 #125323

Uh oh!

reidbaker commented Apr 21, 2023 •

edited

Loading

Uh oh!

reidbaker commented Apr 21, 2023

Uh oh!

stuartmorgan-g Apr 22, 2023

Uh oh!

reidbaker Apr 24, 2023

Uh oh!

reidbaker Apr 25, 2023

Uh oh!

gmackall Apr 26, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Apr 25, 2023

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Apr 27, 2023

Uh oh!

reidbaker Apr 27, 2023

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Test AGP 8.0 using java 17 #125323

Test AGP 8.0 using java 17 #125323

Uh oh!

Conversation

reidbaker commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

reidbaker commented Apr 21, 2023

Uh oh!

stuartmorgan-g Apr 22, 2023

Choose a reason for hiding this comment

Uh oh!

reidbaker Apr 24, 2023

Choose a reason for hiding this comment

Uh oh!

reidbaker Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

gmackall Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Apr 25, 2023

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 27, 2023

Choose a reason for hiding this comment

Uh oh!

reidbaker Apr 27, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

reidbaker commented Apr 21, 2023 •

edited

Loading

gmackall Apr 26, 2023 •

edited

Loading