Skip to content

Revert "Sliver Constrained Cross Axis" #125233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 20, 2023
Merged

Revert "Sliver Constrained Cross Axis" #125233

auto-submit merged 1 commit into from
Apr 20, 2023

Conversation

@thkim1011
Copy link
Contributor

@thkim1011 thkim1011 commented Apr 20, 2023

Going to make some changes to the implementation so I'll revert in the meantime.

Reverts #124337

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 20, 2023
@thkim1011 thkim1011 requested a review from Piinks April 20, 2023 18:43
Piinks
Piinks approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Apr 20, 2023
@auto-submit auto-submit bot merged commit 9caabdd into master Apr 20, 2023
@auto-submit auto-submit bot deleted the revert-124337-tae/sliver-constrained-cross-axis branch April 20, 2023 18:47
@auto-submit auto-submit bot mentioned this pull request Apr 20, 2023
Closed
thkim1011 added a commit to thkim1011/flutter that referenced this pull request Apr 20, 2023
@thkim1011
Revert "Revert "Sliver Constrained Cross Axis" (flutter#125233)"
3e8c671 
This reverts commit 9caabdd.
@thkim1011 thkim1011 mentioned this pull request Apr 20, 2023
Merged
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
3498830
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
48b671e
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
8de6d9b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
9553cd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
c415fda
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
d28e60e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
1877334
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
a380c0c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
4a04b6d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
f82fbdf
auto-submit bot pushed a commit that referenced this pull request Apr 24, 2023
@thkim1011
Sliver Constrained Cross Axis (#125239)
482d1aa 
Reimplements what we reverted here: #125233.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
604ea5b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
9caabdd Revert "Sliver Constrained Cross Axis" (flutter/flutter#125233)
5f1db8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thkim1011 @Piinks @fluttergithubbot