Skip to content

Combine flutter_tool_startup devicelab tests #125226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Apr 21, 2023
Merged

Combine flutter_tool_startup devicelab tests #125226

auto-submit merged 3 commits into from
Apr 21, 2023

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 20, 2023

flutter_tool_startup__windows/linux/macos were identical. Use the same task for all three.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Apr 20, 2023
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 20, 2023
@jmagman jmagman marked this pull request as ready for review April 21, 2023 20:29
@jmagman jmagman mentioned this pull request Apr 21, 2023
Closed
@jmagman
Copy link
Member Author

jmagman commented Apr 21, 2023

Filed #125328 because I didn't update TESTOWNERS but the check still succeeded.

@jmagman jmagman force-pushed the flutter_tool_startup branch from 11fb332 to 989f91a Compare April 21, 2023 20:37
@jmagman
Revert "Update TESTOWNERS"
687e030 
This reverts commit 989f91a.
christopherfujino
christopherfujino approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit auto-submit bot merged commit baafa19 into flutter:master Apr 21, 2023
@jmagman jmagman deleted the flutter_tool_startup branch April 21, 2023 22:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
a98d73b 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
5fdcea7 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
833c7c3 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
84d0e61 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
30f7eb6 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
46e7a5d 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
1594a1d 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
087024c 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
9fb77f3 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
41d1e40 
…er#125226)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
8c2791a 
…er#125226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
d3d0563 
…er#125226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
e0d5f24 
…er#125226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
baafa19 Combine flutter_tool_startup devicelab tests (flutter/flutt…
11e5049 
…er#125226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jensjoha jensjoha Awaiting requested review from jensjoha

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @christopherfujino