Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` #125204

TahaTesser · 2023-04-20T13:35:54Z

fixes #118071

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/lib/src/material/text_button.dart

HansMuller

Thanks for spreading the fix around; this looks great.

LGTM

QuncCccccc

Nice fix! Thanks a lot!

Also noticed that the IconButton has the same problem. Do you mind to add one more fix for IconButton? Or I can add it later after this PR:)

packages/flutter/test/material/outlined_button_test.dart

TahaTesser · 2023-04-24T18:44:33Z

@QuncCccccc
This is unrelated to this PR but I just noticed an empty code exists in the icon_button_test.dart class while adding a test for my fix.

flutter/packages/flutter/test/material/icon_button_test.dart

Lines 2482 to 2484 in 3b4ac4d

    
           testWidgets('black87 icon color defined by users shows correctly in Material3', (WidgetTester tester) async { 
        
           });

Looks like a leftover from #108332

f7b0023#diff-d72818e35a55b09b951ce5020786febe5701370ec2683c7f8b97370d37b18eabR1815-R1817

packages/flutter/lib/src/material/icon_button.dart

packages/flutter/test/material/outlined_button_test.dart

QuncCccccc · 2023-04-24T18:54:24Z

@QuncCccccc This is unrelated to this PR but I just noticed an empty code exists in the icon_button_test.dart class while adding a test for my fix.

flutter/packages/flutter/test/material/icon_button_test.dart

Lines 2482 to 2484 in 3b4ac4d

testWidgets('black87 icon color defined by users shows correctly in Material3', (WidgetTester tester) async {

});

Looks like a leftover from #108332

f7b0023#diff-d72818e35a55b09b951ce5020786febe5701370ec2683c7f8b97370d37b18eabR1815-R1817

OOPS! I cannot even recall why I added this before... Sorry about that. Will remove!

QuncCccccc

LGTM:)

…en passing only one cursor to `styleFrom`

…ception when passing only one cursor to `styleFrom` (flutter/flutter#125204)

Roll Flutter from c9004ff to 66fa4c5 (68 revisions) flutter/flutter@c9004ff...66fa4c5 2023-04-26 [email protected] Remove web compile benchmarks that specify an attached device (flutter/flutter#125559) 2023-04-26 [email protected] Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560) 2023-04-26 [email protected] Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558) 2023-04-26 [email protected] Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555) 2023-04-26 [email protected] Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552) 2023-04-26 [email protected] Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549) 2023-04-26 [email protected] Update prefer_final_parameters comment (flutter/flutter#125465) 2023-04-26 [email protected] Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539) 2023-04-26 [email protected] Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536) 2023-04-26 [email protected] Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533) 2023-04-26 [email protected] Roll Flutter Engine from b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531) 2023-04-26 [email protected] Add hostonly web compile size benchmarks (flutter/flutter#125518) 2023-04-26 [email protected] Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529) 2023-04-25 [email protected] Handle dollar signs properly when generating localizations (flutter/flutter#125514) 2023-04-25 [email protected] Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516) 2023-04-25 [email protected] Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513) 2023-04-25 [email protected] Adds selected semantics flag to radio button for Apple devices (flutter/flutter#125499) 2023-04-25 [email protected] Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510) 2023-04-25 [email protected] Relabel JSFunction as JSExportedDartFunction (flutter/flutter#125453) 2023-04-25 [email protected] Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504) 2023-04-25 [email protected] iOS TextField spell check style (flutter/flutter#125432) 2023-04-25 [email protected] Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490) 2023-04-25 [email protected] Roll Flutter Engine from 54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485) 2023-04-25 [email protected] Roll Flutter Engine from 307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481) 2023-04-25 [email protected] Roll Flutter Engine from 232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475) 2023-04-25 [email protected] Roll Flutter Engine from 1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472) 2023-04-25 [email protected] Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463) 2023-04-25 [email protected] Fix `SliverAppBar.medium` & `SliverAppBar.large` text scale (flutter/flutter#125038) 2023-04-25 [email protected] Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459) 2023-04-25 [email protected] Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458) 2023-04-25 [email protected] Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454) 2023-04-25 [email protected] Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452) 2023-04-24 [email protected] Add Sliders to `macrobenchmarks` (flutter/flutter#125296) 2023-04-24 [email protected] [date_picker] [date_range_picker] add properties to change switch-to icons (flutter/flutter#124881) 2023-04-24 [email protected] Sliver Constrained Cross Axis (flutter/flutter#125239) 2023-04-24 [email protected] tool: Move cdKey to CustomDimensionsEnum (flutter/flutter#125335) 2023-04-24 [email protected] Add `borderRadius` to LinearProgressIndicator (flutter/flutter#123517) 2023-04-24 [email protected] Fix JS types in _test_http_request.dart (flutter/flutter#125220) 2023-04-24 [email protected] Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` (flutter/flutter#125204) 2023-04-24 [email protected] Swap some iOS TESTOWNERS (flutter/flutter#125340) 2023-04-24 [email protected] Fix iOS touch drag behavior (flutter/flutter#125169) 2023-04-24 [email protected] Mark module_test_ios flaky (flutter/flutter#125426) 2023-04-24 [email protected] Implement url support for RouteInformation and didPushRouteInformation (flutter/flutter#119968) 2023-04-24 [email protected] [tool,web] Include more info URI on Wasm init failure (flutter/flutter#125312) 2023-04-24 [email protected] Do not run `windows_home_scroll_perf__timeline_summary` benchmark in presubmit (flutter/flutter#125343) 2023-04-24 [email protected] Tiny fix doc pointing to incorrect widget confusing the readers (flutter/flutter#125394) ...

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 20, 2023

TahaTesser requested review from HansMuller and QuncCccccc April 20, 2023 14:51

HansMuller reviewed Apr 24, 2023

View reviewed changes

packages/flutter/lib/src/material/text_button.dart Outdated Show resolved Hide resolved

TahaTesser force-pushed the fix_button_style_nullable_cursor_error branch from b425c12 to aa1d0b4 Compare April 24, 2023 17:53

TahaTesser requested a review from HansMuller April 24, 2023 17:54

HansMuller approved these changes Apr 24, 2023

View reviewed changes

QuncCccccc approved these changes Apr 24, 2023

View reviewed changes

packages/flutter/test/material/outlined_button_test.dart Outdated Show resolved Hide resolved

TahaTesser force-pushed the fix_button_style_nullable_cursor_error branch from 6913dbf to bf321cd Compare April 24, 2023 18:46

TahaTesser changed the title ~~Fix OutlinedButton & TextButton throw exception when passing only one cursor to styleFrom~~ Fix OutlinedButton, TextButton, and IconButton throw exception when passing only one cursor to styleFrom Apr 24, 2023

QuncCccccc reviewed Apr 24, 2023

View reviewed changes

packages/flutter/lib/src/material/icon_button.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/outlined_button_test.dart Outdated Show resolved Hide resolved

QuncCccccc approved these changes Apr 24, 2023

View reviewed changes

Fix OutlinedButton, TextButton, & IconButton throw exception wh…

81e78aa

…en passing only one cursor to `styleFrom`

TahaTesser force-pushed the fix_button_style_nullable_cursor_error branch from bda0e55 to 81e78aa Compare April 24, 2023 19:17

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2023

auto-submit bot merged commit 38c7c2f into flutter:master Apr 24, 2023

TahaTesser deleted the fix_button_style_nullable_cursor_error branch April 25, 2023 07:19

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 932faedce2f8 (93 revisions) flutter/packages#3813

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

38c7c2f Fix OutlinedButton, TextButton, and IconButton throw ex…

e70c1f4

…ception when passing only one cursor to `styleFrom` (flutter/flutter#125204)

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 8cd11e91fb7d (94 revisions) flutter/packages#3815

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

38c7c2f Fix OutlinedButton, TextButton, and IconButton throw ex…

73db2d9

…ception when passing only one cursor to `styleFrom` (flutter/flutter#125204)

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from c9004ff822cf to 8cd11e91fb7d (47 revisions) flutter/packages#3817

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

38c7c2f Fix OutlinedButton, TextButton, and IconButton throw ex…

4f7ef83

…ception when passing only one cursor to `styleFrom` (flutter/flutter#125204)

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to b0ae2e81bab5 (66 revisions) flutter/packages#3827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

38c7c2f Fix OutlinedButton, TextButton, and IconButton throw ex…

7c372d0

…ception when passing only one cursor to `styleFrom` (flutter/flutter#125204)

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to c9d7bed4216b (67 revisions) flutter/packages#3829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

38c7c2f Fix OutlinedButton, TextButton, and IconButton throw ex…

fe81c89

…ception when passing only one cursor to `styleFrom` (flutter/flutter#125204)

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) flutter/packages#3830

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

38c7c2f Fix OutlinedButton, TextButton, and IconButton throw ex…

c8312ff

…ception when passing only one cursor to `styleFrom` (flutter/flutter#125204)

HansMuller mentioned this pull request Apr 28, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` #125204

Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` #125204

Uh oh!

TahaTesser commented Apr 20, 2023

Uh oh!

Uh oh!

HansMuller left a comment

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

TahaTesser commented Apr 24, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

QuncCccccc commented Apr 24, 2023

Uh oh!

QuncCccccc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix OutlinedButton, TextButton, and IconButton throw exception when passing only one cursor to styleFrom #125204

Fix OutlinedButton, TextButton, and IconButton throw exception when passing only one cursor to styleFrom #125204

Uh oh!

Conversation

TahaTesser commented Apr 20, 2023

Pre-launch Checklist

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TahaTesser commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuncCccccc commented Apr 24, 2023

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` #125204

Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` #125204

TahaTesser commented Apr 24, 2023 •

edited

Loading