Skip to content

Show magnifier on touch drag gestures #125151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Apr 20, 2023
Merged

Show magnifier on touch drag gestures #125151

auto-submit merged 3 commits into from
Apr 20, 2023

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Apr 19, 2023 •
edited
Loading

This change shows the magnifier on touch drag gestures for Android and iOS and hides it when the drag ends.

Screen.Recording.2023-04-19.at.5.14.25.PM.mov

Fixes #118268

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 19, 2023
@Renzo-Olivares Renzo-Olivares requested a review from justinmc April 19, 2023 20:50
justinmc
justinmc approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm not sure how we missed this when the magnifier was first implemented. Thanks for fixing it. It's probably pretty obvious, especially on iOS.

packages/flutter/lib/src/widgets/text_selection.dart
case TargetPlatform.macOS:
case TargetPlatform.windows:
break;
}
Copy link
Contributor

@justinmc justinmc Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call abstracting all of this.

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023
@flutter-dashboard flutter-dashboard bot added the f: cupertino flutter/packages/flutter/cupertino repository label Apr 20, 2023
@auto-submit auto-submit bot merged commit 8ed26d8 into flutter:master Apr 20, 2023
@Renzo-Olivares Renzo-Olivares mentioned this pull request Apr 20, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
c433f4a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
32e0ea9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
06f5a5d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
04c11c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
a75ff4f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
d8792f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
cd7cf2d
@reidbaker reidbaker mentioned this pull request Apr 20, 2023
Closed
8 tasks
auto-submit bot pushed a commit that referenced this pull request Apr 20, 2023
@Renzo-Olivares
Toolbar should re-appear on drag end (#125165)
01b4dd5 
#125151 introduced the magnifier on touch drag gestures, but when showing the magnifier the toolbar is implicitly hidden, this change makes the toolbar re-appear on drag end for double tap + drag.
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Closed
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
7c50dff
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
c896ffe
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
93159f0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
b90cdad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
c79e53d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
84b4b01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
7f0b815
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
fb2db6f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
fb507bb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
b785f1c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
adce63a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
314ef37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8ed26d8 Show magnifier on touch drag gestures (flutter/flutter#125151)
47777bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dragging the collapsed cursor doesn't match native

2 participants

@Renzo-Olivares @justinmc