Skip to content

i125138 abstract method smoke agp update #125139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 20, 2023
Merged

i125138 abstract method smoke agp update #125139

auto-submit merged 2 commits into from
Apr 20, 2023

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Apr 19, 2023

To update successfully:
1. Update gradle to a version supported by jdk 17
2. Uncommented the lockfile lines in android/build.gradle
3. Then ran the AGP update assistant from AndroidStudio -> tools
4. From android ran ./gradlew dependencies --write-locks
5. From android/app ran ./gradlew dependencies --write-locks
6. Re enabled the lockfiles section of android/build.gradle
7. Ensured flutter build apk passed

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker
Update gradle and AGP version for abstract_method_smoke_test
c9b9a84 
To update successfully:
1. Update gradle to a version supported by jdk 17
2. Uncommented the lockfile lines in android/build.gradle
3. Then ran the AGP update assistant from AndroidStudio -> tools
4. From android ran `./gradlew dependencies --write-locks`
5. From android/app ran `./gradlew dependencies --write-locks`
6. Re enabled the lockfiles section of android/build.gradle
7. Ensured `flutter build apk` passed
@reidbaker reidbaker marked this pull request as draft April 19, 2023 16:11
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 19, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 19, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g
stuartmorgan-g approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker reidbaker marked this pull request as ready for review April 19, 2023 18:42
@reidbaker
Copy link
Contributor Author

reidbaker commented Apr 19, 2023

Test exemption request made https://discord.com/channels/608014603317936148/608018585025118217/1098319188348641310

@Hixie
Copy link
Contributor

Hixie commented Apr 19, 2023

test-exempt: is a test

bonus points for adding the integration_tests directory to the logic in the bot that decides if you've touched a test

@reidbaker reidbaker added platform-android Android applications specifically autosubmit Merge PR when tree becomes green via auto submit App labels Apr 20, 2023
@auto-submit auto-submit bot merged commit 6459135 into flutter:master Apr 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
714c985 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
77f044d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
339c769 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
c420849 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
1147309 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
9c52d03 
)
This was referenced Apr 20, 2023
Closed
Closed
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Closed
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
6d8baa5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
144abb0 
)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
@jmagman jmagman mentioned this pull request Apr 21, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
efb88b2 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
6451837 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
5af8920 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
b57c862 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
68770d4 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
7140774 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
ae3935c 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
22a9779 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
39de698 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
bb57671 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
6459135 i125138 abstract method smoke agp update (flutter/flutter#125139
aa78ffb 
)
auto-submit bot pushed a commit that referenced this pull request May 15, 2023
@reidbaker
Revert "i125138 abstract method smoke agp update (#125139)" (#126274)
c5b31e7 
This reverts commit 6459135.

#125331 
https://ci.chromium.org/p/flutter/builders/staging/Linux%20firebase_abstract_method_smoke_test?cursor=id%3E8783275059678311409&limit=200

- [ x I signed the [CLA].
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@reidbaker
Revert "i125138 abstract method smoke agp update (flutter#125139)" (f…
08f7a0f 
…lutter#126274)

This reverts commit 6459135.

flutter#125331 
https://ci.chromium.org/p/flutter/builders/staging/Linux%20firebase_abstract_method_smoke_test?cursor=id%3E8783275059678311409&limit=200

- [ x I signed the [CLA].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@zanderso zanderso Awaiting requested review from zanderso

@gmackall gmackall Awaiting requested review from gmackall

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. platform-android Android applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @Hixie @stuartmorgan-g