Skip to content

Report web compiler used with buildEventSettings #125092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 6 commits into from
Apr 19, 2023
Merged

Report web compiler used with buildEventSettings #125092

auto-submit merged 6 commits into from
Apr 19, 2023

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 19, 2023 •
edited
Loading

Fixes #125085

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 19, 2023
@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 19, 2023

@zanderso @christopherfujino – buildEventSettings seemed like a good way to do things, but I don't see any (other) current usages.

christopherfujino
christopherfujino approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023
zanderso
zanderso reviewed Apr 19, 2023
View reviewed changes
@zanderso zanderso removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023
@zanderso
Copy link
Member

zanderso commented Apr 19, 2023

Sorry to remove autosubmit. Wanted to make sure my question is seen before this lands.

zanderso
zanderso approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ nit

zanderso
zanderso reviewed Apr 19, 2023
View reviewed changes
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023
zanderso
zanderso approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@auto-submit auto-submit bot merged commit f5b0f0a into master Apr 19, 2023
@auto-submit auto-submit bot deleted the i125085_report_web_compiler branch April 19, 2023 22:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
39a509b 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
d945409 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
a6543d1 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
1cb1406 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
1615512 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
c6e52c9 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
881d4d9 
…lutter#125092)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
baf9b66 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
033630b 
…lutter#125092)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
df24eed 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
d95cdf8 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
00d592d 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
3162987 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
e7db36c 
…lutter#125092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
f8b0f56 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
af2b246 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
0887ff1 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
a804fe1 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
29d19fc 
…lutter#125092)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
f5b0f0a Report web compiler used with buildEventSettings (flutter/f…
a70d22a 
…lutter#125092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flutter CLI analytics: Capture web compiler in an event, not in a timing

3 participants

@kevmoo @zanderso @christopherfujino