Skip to content

Dismiss the docked search view when the window size is changed #125071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 5 commits into from
Apr 19, 2023
Merged

Dismiss the docked search view when the window size is changed #125071

QuncCccccc merged 5 commits into from
Apr 19, 2023

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Apr 18, 2023 •
edited
Loading

Fixes #125073

This PR is to make an improvement for SearchAnchor. When the window size changes, the search view route should:

  • be popped, if search view is docked(not full-screen).
  • stay open, if it is a full-screen search view.
PR_desktop_demo.mov
PR_mobile_demo.mov

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 18, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review April 18, 2023 22:51
@QuncCccccc QuncCccccc requested a review from HansMuller April 18, 2023 22:51
HansMuller
HansMuller reviewed Apr 19, 2023
View reviewed changes
packages/flutter/lib/src/material/search_anchor.dart Outdated
_viewRect = topLeft & updatedViewSize;
}
});
assert(_screenSize != null);
Copy link
Contributor

@HansMuller HansMuller Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the previous line be

_screenSize = updatedScreenSize!;

Copy link
Contributor Author

@QuncCccccc QuncCccccc Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. Removed the assert check. Thanks!

HansMuller
HansMuller approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc merged commit 4c6929d into flutter:master Apr 19, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
269a619 
flutter/flutter#125071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
5b01a2f 
flutter/flutter#125071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
3f2bba2 
flutter/flutter#125071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
d0c21ca 
flutter/flutter#125071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
11c9f4a 
flutter/flutter#125071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
2636d33 
flutter/flutter#125071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
3ec03b7 
flutter/flutter#125071)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
0be48bd 
flutter/flutter#125071)
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
1924199 
flutter/flutter#125071)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
dd55076 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
4cfdca9 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
1832a61 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
7336753 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
3ce858b 
flutter/flutter#125071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
bbb09f7 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
eee0541 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
a2bfb5e 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
ba33ded 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
6864ba5 
flutter/flutter#125071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
4c6929d Dismiss the docked search view when the window size is changed (
808f629 
flutter/flutter#125071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SearchAnchor doesn't work if app layout changes

2 participants

@QuncCccccc @HansMuller