flutter · auto-submit · Jul 17, 2023 · Apr 10, 2023 · Apr 11, 2023 · Apr 11, 2023
diff --git a/dev/benchmarks/microbenchmarks/lib/stocks/layout_bench.dart b/dev/benchmarks/microbenchmarks/lib/stocks/layout_bench.dart
@@ -39,7 +39,7 @@ Future<void> main() async {
       size: const Size(355.0, 635.0),
       view: tester.view,
     );
-    final RenderView renderView = WidgetsBinding.instance.renderView;
+    final RenderView renderView = WidgetsBinding.instance.renderViews.single;
     binding.framePolicy = LiveTestWidgetsFlutterBindingFramePolicy.benchmark;
 
     watch.start();

diff --git a/dev/bots/test.dart b/dev/bots/test.dart
@@ -1361,7 +1361,7 @@ Future<void> _runWebTreeshakeTest() async {
   final String javaScript = mainDartJs.readAsStringSync();
 
   // Check that we're not looking at minified JS. Otherwise this test would result in false positive.
-  expect(javaScript.contains('RenderObjectToWidgetElement'), true);
+  expect(javaScript.contains('RootElement'), true);
 
   const String word = 'debugFillProperties';
   int count = 0;

diff --git a/dev/integration_tests/flutter_gallery/test/smoke_test.dart b/dev/integration_tests/flutter_gallery/test/smoke_test.dart
@@ -79,8 +79,8 @@ Future<void> smokeDemo(WidgetTester tester, GalleryDemo demo) async {
   // Verify that the dumps are pretty.
   final String routeName = demo.routeName;
   verifyToStringOutput('debugDumpApp', routeName, WidgetsBinding.instance.rootElement!.toStringDeep());
-  verifyToStringOutput('debugDumpRenderTree', routeName, RendererBinding.instance.renderView.toStringDeep());
-  verifyToStringOutput('debugDumpLayerTree', routeName, RendererBinding.instance.renderView.debugLayer?.toStringDeep() ?? '');
+  verifyToStringOutput('debugDumpRenderTree', routeName, RendererBinding.instance.renderViews.single.toStringDeep());
+  verifyToStringOutput('debugDumpLayerTree', routeName, RendererBinding.instance.renderViews.single.debugLayer?.toStringDeep() ?? '');
   verifyToStringOutput('debugDumpFocusTree', routeName, WidgetsBinding.instance.focusManager.toStringDeep());
 
   // Scroll the demo around a bit more.

diff --git a/examples/layers/rendering/custom_coordinate_systems.dart b/examples/layers/rendering/custom_coordinate_systems.dart
@@ -6,6 +6,7 @@
 // system. Most of the guts of this examples are in src/sector_layout.dart.
 
 import 'package:flutter/rendering.dart';
+import 'src/binding.dart';
 import 'src/sector_layout.dart';
 
 RenderBox buildSectorExample() {
@@ -21,5 +22,5 @@ RenderBox buildSectorExample() {
 }
 
 void main() {
-  RenderingFlutterBinding(root: buildSectorExample()).scheduleFrame();
+  ViewRenderingFlutterBinding(root: buildSectorExample()).scheduleFrame();
 }
diff --git a/examples/layers/rendering/flex_layout.dart b/examples/layers/rendering/flex_layout.dart
@@ -7,6 +7,7 @@
 
 import 'package:flutter/rendering.dart';
 
+import 'src/binding.dart';
 import 'src/solid_color_box.dart';
 
 void main() {
@@ -86,5 +87,5 @@ void main() {
     child: RenderPadding(child: table, padding: const EdgeInsets.symmetric(vertical: 50.0)),
   );
 
-  RenderingFlutterBinding(root: root).scheduleFrame();
+  ViewRenderingFlutterBinding(root: root).scheduleFrame();
 }
diff --git a/examples/layers/rendering/hello_world.dart b/examples/layers/rendering/hello_world.dart
@@ -7,9 +7,11 @@
 
 import 'package:flutter/rendering.dart';
 
+import 'src/binding.dart';
+
 void main() {
-  // We use RenderingFlutterBinding to attach the render tree to the window.
-  RenderingFlutterBinding(
+  // We use ViewRenderingFlutterBinding to attach the render tree to the window.
+  ViewRenderingFlutterBinding(
     // The root of our render tree is a RenderPositionedBox, which centers its
     // child both vertically and horizontally.
     root: RenderPositionedBox(

diff --git a/examples/layers/rendering/spinning_square.dart b/examples/layers/rendering/spinning_square.dart
@@ -11,6 +11,8 @@ import 'package:flutter/animation.dart';
 import 'package:flutter/rendering.dart';
 import 'package:flutter/scheduler.dart';
 
+import 'src/binding.dart';
+
 class NonStopVSync implements TickerProvider {
   const NonStopVSync();
   @override
@@ -42,7 +44,7 @@ void main() {
     child: spin,
   );
   // and attach it to the window.
-  RenderingFlutterBinding(root: root);
+  ViewRenderingFlutterBinding(root: root);
 
   // To make the square spin, we use an animation that repeats every 1800
   // milliseconds.

diff --git a/examples/layers/rendering/src/binding.dart b/examples/layers/rendering/src/binding.dart
@@ -0,0 +1,69 @@
+// Copyright 2014 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'dart:ui';
+
+import 'package:flutter/rendering.dart';
+
+/// An extension of [RenderingFlutterBinding] that owns and manages a
+/// [renderView].
+///
+/// Unlike [RenderingFlutterBinding], this binding also creates and owns a
+/// [renderView] to simplify bootstrapping for apps that have a dedicated main
+/// view.
+class ViewRenderingFlutterBinding extends RenderingFlutterBinding {
+  /// Creates a binding for the rendering layer.
+  ///
+  /// The `root` render box is attached directly to the [renderView] and is
+  /// given constraints that require it to fill the window. The [renderView]
+  /// itself is attached to the [rootPipelineOwner].
+  ///
+  /// This binding does not automatically schedule any frames. Callers are
+  /// responsible for deciding when to first call [scheduleFrame].
+  ViewRenderingFlutterBinding({ RenderBox? root }) : _root = root;
+
+  @override
+  void initInstances() {
+    super.initInstances();
+    // TODO(goderbauer): Create window if embedder doesn't provide an implicit view.
+    assert(PlatformDispatcher.instance.implicitView != null);
+    _renderView = initRenderView(PlatformDispatcher.instance.implicitView!);
+    _renderView.child = _root;
+    _root = null;
+  }
+
+  RenderBox? _root;
+
+  @override
+  RenderView get renderView => _renderView;
+  late RenderView _renderView;
+
+  /// Creates a [RenderView] object to be the root of the
+  /// [RenderObject] rendering tree, and initializes it so that it
+  /// will be rendered when the next frame is requested.
+  ///
+  /// Called automatically when the binding is created.
+  RenderView initRenderView(FlutterView view) {
+    final RenderView renderView = RenderView(view: view);
+    rootPipelineOwner.rootNode = renderView;
+    addRenderView(renderView);
+    renderView.prepareInitialFrame();
+    return renderView;
+  }
+
+  @override
+  PipelineOwner createRootPipelineOwner() {
+    return PipelineOwner(
+      onSemanticsOwnerCreated: () {
+        renderView.scheduleInitialSemantics();
+      },
+      onSemanticsUpdate: (SemanticsUpdate update) {
+        renderView.updateSemantics(update);
+      },
+      onSemanticsOwnerDisposed: () {
+        renderView.clearSemantics();
+      },
+    );
+  }
+}
diff --git a/examples/layers/rendering/touch_input.dart b/examples/layers/rendering/touch_input.dart
@@ -8,6 +8,8 @@
 import 'package:flutter/material.dart'; // Imported just for its color palette.
 import 'package:flutter/rendering.dart';
 
+import 'src/binding.dart';
+
 // Material design colors. :p
 List<Color> _kColors = <Color>[
   Colors.teal,
@@ -133,5 +135,5 @@ void main() {
     ..left = 20.0;
 
   // Finally, we attach the render tree we've built to the screen.
-  RenderingFlutterBinding(root: stack).scheduleFrame();
+  ViewRenderingFlutterBinding(root: stack).scheduleFrame();
 }
diff --git a/examples/layers/widgets/spinning_mixed.dart b/examples/layers/widgets/spinning_mixed.dart
@@ -52,10 +52,10 @@ void attachWidgetTreeToRenderTree(RenderProxyBox container) {
                   mainAxisAlignment: MainAxisAlignment.spaceAround,
                   children: <Widget>[
                     ElevatedButton(
-                      child: Row(
+                      child: const Row(
                         children: <Widget>[
-                          Image.network('https://flutter.dev/images/favicon.png'),
-                          const Text('PRESS ME'),
+                          FlutterLogo(),
+                          Text('PRESS ME'),
                         ],
                       ),
                       onPressed: () {
@@ -102,6 +102,16 @@ void main() {
   transformBox = RenderTransform(child: flexRoot, transform: Matrix4.identity(), alignment: Alignment.center);
   final RenderPadding root = RenderPadding(padding: const EdgeInsets.all(80.0), child: transformBox);
 
-  binding.renderView.child = root;
+  // TODO(goderbauer): Create a window if embedder doesn't provide an implicit view to draw into.
+  assert(binding.platformDispatcher.implicitView != null);
+  final RenderView view = RenderView(
+    view: binding.platformDispatcher.implicitView!,
+    child: root,
+  );
+  final PipelineOwner pipelineOwner = PipelineOwner()..rootNode = view;
+  binding.rootPipelineOwner.adoptChild(pipelineOwner);
+  binding.addRenderView(view);
+  view.prepareInitialFrame();
+
   binding.addPersistentFrameCallback(rotate);
 }