-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Remove token permissions for coverage. #124909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
flutter:master
from
godofredoc:remove_token_permissions
Apr 17, 2023
Merged
Remove token permissions for coverage. #124909
auto-submit
merged 1 commit into
flutter:master
from
godofredoc:remove_token_permissions
Apr 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coverage build does not require write access to checks.
keyonghan
approved these changes
Apr 17, 2023
Contributor
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 17, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 18, 2023
Manual roll requested by [email protected] flutter/flutter@50171bb...15cb1f8 2023-04-17 [email protected] Fix Chip highlight color isn't drawn on top of the background color (flutter/flutter#124673) 2023-04-17 [email protected] Deprecates string for reorderable list in material_localizations (flutter/flutter#124711) 2023-04-17 [email protected] Fix a null crash in SelectableRegion Widget (flutter/flutter#124736) 2023-04-17 [email protected] Customize color and thickness of connected lines in Stepper.dart (flutter/flutter#122485) 2023-04-17 [email protected] Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (flutter/flutter#124987) 2023-04-17 [email protected] Remove token permissions for coverage. (flutter/flutter#124909) 2023-04-17 [email protected] Roll Packages from e4ec155 to 0277f2a (9 revisions) (flutter/flutter#124972) 2023-04-17 [email protected] Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (flutter/flutter#124963) 2023-04-17 [email protected] Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (flutter/flutter#124952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Apr 20, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
Manual roll requested by [email protected] flutter/flutter@50171bb...15cb1f8 2023-04-17 [email protected] Fix Chip highlight color isn't drawn on top of the background color (flutter/flutter#124673) 2023-04-17 [email protected] Deprecates string for reorderable list in material_localizations (flutter/flutter#124711) 2023-04-17 [email protected] Fix a null crash in SelectableRegion Widget (flutter/flutter#124736) 2023-04-17 [email protected] Customize color and thickness of connected lines in Stepper.dart (flutter/flutter#122485) 2023-04-17 [email protected] Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (flutter/flutter#124987) 2023-04-17 [email protected] Remove token permissions for coverage. (flutter/flutter#124909) 2023-04-17 [email protected] Roll Packages from e4ec155 to 0277f2a (9 revisions) (flutter/flutter#124972) 2023-04-17 [email protected] Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (flutter/flutter#124963) 2023-04-17 [email protected] Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (flutter/flutter#124952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage build does not require write access to checks.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.