Show iOS menu on iOS for TextField by default #124895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
camsim99
approved these changes
Apr 19, 2023
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
Looks good to me! Left one nit and a question about the old toolbar constructors.
|
|
||
| if (buttonItems == null){ | ||
| return const SizedBox.shrink(); | ||
| switch (defaultTargetPlatform) { |
Contributor
There was a problem hiding this comment.
Can you update the documentation on this method to explain the adaptiveness of the toolbar implemented here?
Contributor
Author
There was a problem hiding this comment.
Yes, good catch, it's out of date now.
| /// See also: | ||
| /// * [SpellCheckSuggestionsToolbar.editableText], which is similar but | ||
| /// builds an Android-style toolbar. | ||
| CupertinoSpellCheckSuggestionsToolbar.editableText({ |
Contributor
There was a problem hiding this comment.
I'm curious -- with the editableText named constructors, do we need the other ones?
Contributor
Author
There was a problem hiding this comment.
- A
children-based constructor - Could be useful for advanced customization. - A plain
editableconstructor - Could be useful for custom text editors. selectableorselectableRegion- Unlikely to be useful because users probably don't want to spell check non-editable text?
I think let's wait and see if anyone opens some issues asking for these. I would be up for it if they did though.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 20, 2023
This was referenced Apr 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 25, 2023
justinmc
added a commit
to justinmc/flutter
that referenced
this pull request
Apr 25, 2023
Even in TextField using the Material library, iOS devices will still show the iOS-style spell check toolbar by default when using spell check.
itsjustkevin
pushed a commit
that referenced
this pull request
Apr 26, 2023
This is a cherry pick of 8 of my recent spell check bug fixes into the beta branch. 1. #124259 2. #124875 3. #124254 4. #124899 5. #124895 6. #125162 7. #124897 8. #125432 This is the behavior of spell check with these changes: | Screenshot | Video | | --- | --- | | <img src="https://user-images.githubusercontent.com/389558/234087650-bcd62c89-03e7-427d-afc5-0fe8f96a5f80.png" /> | <video src="https://user-images.githubusercontent.com/389558/234087667-651b0fde-348c-467e-ba00-27b6b3966a27.mov" /> | CC @itsjustkevin @leighajarett
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Android-style spell check menu was shown by default for TextField, even on iOS. Instead, this should behave like AdaptiveTextSelectionToolbar:
Partial fix for: #124882
Waiting on: #124254The overflow will be handled in another PR.