Remove package:js/dart:js_interop conflicts #124879

srujzs · 2023-04-14T18:25:31Z

dart:js_interop and package:js will start conflicting, since they both have an @JS annotation. Until we're ready to only use dart:js_interop (which will require updating the SDK constraints of every package), we should hide the @JS annotation from dart:js_interop. Due to shadowing, this is the behavior today, so there should be no functional change.

Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and prevents confusing shadowing of dart:js_interop annotations like we do today.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
[Mentioned CL that is unblocked] I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
[Need test-exemption] I added new tests to check the change I am making, or this PR is [test-exempt].
[Need to run] All existing and new tests are passing.

flutter-dashboard · 2023-04-14T18:25:35Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

srujzs · 2023-04-14T20:18:13Z

@eyebrowsoffire PTAL, thanks!

Hixie · 2023-04-17T20:50:27Z

test-exempt: preparing for dependency roll

eyebrowsoffire

Small nit: would you mind dropping a comment explaining why we need to hide JS? (It makes sense to me, but I think it would be nice for someone just reading the code to know that you're trying to avoid a conflict with package:js)

@js

dart:js_interop and package:js will start conflicting, since they both have an @js annotation. Until we're ready to only use dart:js_interop (which will require updating the SDK constraints of every package), we should hide the @js annotation from dart:js_interop. Due to shadowing, this is the behavior today, so there should be no functional change.

srujzs · 2023-04-17T23:26:42Z

Small nit: would you mind dropping a comment explaining why we need to hide JS? (It makes sense to me, but I think it would be nice for someone just reading the code to know that you're trying to avoid a conflict with package:js)

Done, thanks!

auto-submit · 2023-04-18T21:52:51Z

auto label is removed for flutter/flutter, pr: 124879, due to This PR has not met approval requirements for merging. You have project association CONTRIBUTOR and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2023-04-18T21:52:52Z

auto label is removed for flutter/flutter, pr: 124879, due to Validations Fail.

Piinks

…124879)

flutter/flutter@42fb0b2...3476b96 2023-04-19 [email protected] Update helper message for `--suppress-analytics` (flutter/flutter#124810) 2023-04-19 [email protected] Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) (flutter/flutter#125097) 2023-04-19 [email protected] Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) (flutter/flutter#125094) 2023-04-19 [email protected] Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) (flutter/flutter#125078) 2023-04-19 [email protected] Disableable ContextMenuButtonItems (flutter/flutter#124253) 2023-04-18 [email protected] Adaptive alert dialog (flutter/flutter#124336) 2023-04-18 [email protected] Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (flutter/flutter#125069) 2023-04-18 [email protected] Remove package:js/dart:js_interop conflicts (flutter/flutter#124879) 2023-04-18 [email protected] Remove double.fromEnvironment from dart-define doc (flutter/flutter#124102) 2023-04-18 [email protected] Update to add Kim Jiun to `AUTHORS` (flutter/flutter#125026) 2023-04-18 [email protected] Add controller argument to SubmenuButton (flutter/flutter#125000) 2023-04-18 [email protected] Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (flutter/flutter#125060) 2023-04-18 [email protected] Limit the number of Material spell check suggestions to 3 (flutter/flutter#124899) 2023-04-18 [email protected] Remove impeller testowners (flutter/flutter#125056) 2023-04-18 [email protected] [web] - Clean up skipped tests (flutter/flutter#124981) 2023-04-18 [email protected] Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (flutter/flutter#125057) 2023-04-18 [email protected] Remove unused getRootRenderObject and getSelectedRenderObject service extensions (flutter/flutter#124805) 2023-04-18 [email protected] l10n.yaml's nullable-getter option should default to true (flutter/flutter#124353) 2023-04-18 [email protected] Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (flutter/flutter#125053) 2023-04-18 [email protected] Add vmservice for android build options (flutter/flutter#123034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 14, 2023

srujzs force-pushed the master branch 3 times, most recently from 02cc46d to d9e6745 Compare April 17, 2023 20:26

srujzs changed the title ~~Remove reference to package:js~~ Remove package:js/dart:js_interop conflicts Apr 17, 2023

eyebrowsoffire approved these changes Apr 17, 2023

View reviewed changes

srujzs force-pushed the master branch from d9e6745 to 69e0b6a Compare April 17, 2023 23:25

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023

Piinks approved these changes Apr 18, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023

auto-submit bot merged commit 6edbc19 into flutter:master Apr 18, 2023

engine-flutter-autoroll mentioned this pull request Apr 19, 2023

Roll Flutter from 42fb0b23139c to 3476b966524f (20 revisions) flutter/packages#3760

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2023

6edbc19 Remove package:js/dart:js_interop conflicts (flutter/flutter#…

4207839

…124879)

This was referenced Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

[integration_test] add support for agp8.0 #125310

Closed

Test AGP 8.0 using java 17 #125323

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove package:js/dart:js_interop conflicts #124879

Remove package:js/dart:js_interop conflicts #124879

Uh oh!

srujzs commented Apr 14, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Apr 14, 2023

Uh oh!

srujzs commented Apr 14, 2023

Uh oh!

Hixie commented Apr 17, 2023

Uh oh!

eyebrowsoffire left a comment

Uh oh!

srujzs commented Apr 17, 2023

Uh oh!

auto-submit bot commented Apr 18, 2023

Uh oh!

auto-submit bot commented Apr 18, 2023

Uh oh!

Piinks left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove package:js/dart:js_interop conflicts #124879

Remove package:js/dart:js_interop conflicts #124879

Uh oh!

Conversation

srujzs commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Apr 14, 2023

Uh oh!

srujzs commented Apr 14, 2023

Uh oh!

Hixie commented Apr 17, 2023

Uh oh!

eyebrowsoffire left a comment

Choose a reason for hiding this comment

Uh oh!

srujzs commented Apr 17, 2023

Uh oh!

auto-submit bot commented Apr 18, 2023

Uh oh!

auto-submit bot commented Apr 18, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

srujzs commented Apr 14, 2023 •

edited

Loading