Skip to content

fix DropdownMenu crash when resize window during menu showing #124855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 2 commits into from
Apr 19, 2023
Merged

fix DropdownMenu crash when resize window during menu showing #124855

QuncCccccc merged 2 commits into from
Apr 19, 2023

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Apr 14, 2023

Fixes #124854

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 14, 2023
@xu-baolin xu-baolin requested a review from QuncCccccc April 14, 2023 09:13
@xu-baolin xu-baolin changed the title fix DropdownMenu crash bug fix DropdownMenu crash when resize window during menu showing Apr 14, 2023
@QuncCccccc
Copy link
Contributor

QuncCccccc commented Apr 17, 2023

Thanks so much for the fix! Will take a look very soon👍!

QuncCccccc
QuncCccccc reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:)! Just left one minor comment.

packages/flutter/lib/src/material/menu_anchor.dart Outdated
Copy link
Contributor

@QuncCccccc QuncCccccc Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we don't need the comment here or not mention the "IconButton" since it is unrelated:)

QuncCccccc
QuncCccccc approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@QuncCccccc QuncCccccc added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 19, 2023
@QuncCccccc QuncCccccc merged commit 73f7945 into flutter:master Apr 19, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
edc6cee 
…flutter/flutter#124855)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
dad3b61 
…flutter/flutter#124855)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
3ff1cde 
…flutter/flutter#124855)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
b5b1010 
…flutter/flutter#124855)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
8726ad4 
…flutter/flutter#124855)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
5e7e7a8 
…flutter/flutter#124855)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
b63953f 
…flutter/flutter#124855)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
1af1fe0 
…flutter/flutter#124855)
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
7e37993 
…flutter/flutter#124855)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
e102ae1 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
661c11c 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
5d082e8 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
9c164b6 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
88a3ec7 
…flutter/flutter#124855)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
d3cfded 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
e7ef1eb 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
0b8ed8a 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
e5bc3ac 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
e8efb64 
…flutter/flutter#124855)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
73f7945 fix DropdownMenu crash when resize window during menu showing (…
8f1d18b 
…flutter/flutter#124855)
@erojostt
Copy link

erojostt commented Jun 23, 2023

Hi, as of Flutter v3.10.0, this fix (#124855) is not available. Does anybody know in which version will it be released?

Thanks in advance.

@QuncCccccc
Copy link
Contributor

QuncCccccc commented Jun 23, 2023

Hi, as of Flutter v3.10.0, this fix (#124855) is not available. Does anybody know in which version will it be released?

Thanks in advance.

Hello! The fix will be included in v3.10.0-11.0.pre:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownMenu crash if resize the window during the menu opening

3 participants

@xu-baolin @QuncCccccc @erojostt