Skip to content

DropdownMenu.width should support updating at runtime #124847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 20, 2023
Merged

DropdownMenu.width should support updating at runtime #124847

auto-submit merged 2 commits into from
Apr 20, 2023

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Apr 14, 2023

Fixes #120567

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 14, 2023
@xu-baolin xu-baolin requested a review from QuncCccccc April 14, 2023 09:13
QuncCccccc
QuncCccccc approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution:)

@xu-baolin xu-baolin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 20, 2023
@auto-submit auto-submit bot merged commit 9f2e708 into flutter:master Apr 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
f9b5a27 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
cbefe01 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
22c51ec 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
180f5a5 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
c378418 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
c0a6ace 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
cf8ccba 
…ter/flutter#124847)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
04a3eff 
…ter/flutter#124847)
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
68f0681 
…ter/flutter#124847)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
a0b2a11 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
0e3c9e6 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
82d276c 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
6519d91 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
e110a9b 
…ter/flutter#124847)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
6868f52 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
3f97b08 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
fed7b87 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
28e0bf8 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
2fd0d94 
…ter/flutter#124847)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
9f2e708 DropdownMenu.width should support updating at runtime (flut…
ea3d6d0 
…ter/flutter#124847)
@kulame
Copy link

kulame commented Sep 1, 2023

great, i need this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownMenu width does not update when context changes

3 participants

@xu-baolin @kulame @QuncCccccc