Skip to content

[CP][ci.yaml] Disable packaging_test on release candidates (#124712) #124814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyHillers merged 1 commit into from
Apr 14, 2023
Merged

[CP][ci.yaml] Disable packaging_test on release candidates (#124712) #124814

CaseyHillers merged 1 commit into from
Apr 14, 2023

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Apr 13, 2023

[ci.yaml] Disable packaging_test on release candidates

These tests should not run on RC branches.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

[ci.yaml] Disable packaging_test on release candidates (flutter#124712)
92ce34a 
[ci.yaml] Disable packaging_test on release candidates
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 13, 2023

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@CaseyHillers CaseyHillers mentioned this pull request Apr 13, 2023
Closed
Jasguerrero
Jasguerrero approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers merged commit 8b14043 into flutter:flutter-3.10-candidate.1 Apr 14, 2023
@CaseyHillers CaseyHillers deleted the flutter-3.10-candidate.1 branch April 14, 2023 15:32
@reidbaker reidbaker mentioned this pull request Apr 28, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
8b14043e1 [CP][ci.yaml] Disable packaging_test on release candidates …
0cbdc6c 
…(#124712) (flutter/flutter#124814)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
8b14043e1 [CP][ci.yaml] Disable packaging_test on release candidates …
817f908 
…(#124712) (flutter/flutter#124814)
@reidbaker reidbaker mentioned this pull request May 31, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

+2 more reviewers

@Jasguerrero Jasguerrero Jasguerrero approved these changes

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyHillers @Jasguerrero @XilaiZhang @fluttergithubbot