Skip to content

Implement CheckmarkableChipAttributes on ChoiceChip #124743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 15 commits into from
Apr 20, 2023
Merged

Implement CheckmarkableChipAttributes on ChoiceChip #124743

HansMuller merged 15 commits into from
Apr 20, 2023

Conversation

@9oya
Copy link
Contributor

@9oya 9oya commented Apr 12, 2023 •
edited
Loading

I believe that there is a mistake in the implementation of the ChoiceChip widget as it does not have the CheckmarkableChipAttributes property like the FilterChip and InputChip widgets. To address this issue, I have added the implementation of CheckmarkableChipAttributes to ChoiceChip like the other widgets. Additionally, I have created issue #124662

fixes #124662

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 12, 2023
This was referenced Apr 14, 2023
Closed
Closed
@9oya
Copy link
Contributor Author

9oya commented Apr 14, 2023

@TahaTesser @huycozy @GayathrideviGA Please review this PR before merge this PR

@TahaTesser TahaTesser requested a review from HansMuller April 18, 2023 12:52
@HansMuller HansMuller requested a review from TahaTesser April 18, 2023 15:34
TahaTesser
TahaTesser requested changes Apr 19, 2023
View reviewed changes
@TahaTesser TahaTesser mentioned this pull request Apr 19, 2023
Closed
8 tasks
@9oya
Copy link
Contributor Author

9oya commented Apr 19, 2023

Thanks for reviewing my PR, @TahaTesser. I checked all your comments and applied them. Thanks!

@9oya 9oya requested a review from TahaTesser April 20, 2023 03:44
TahaTesser
TahaTesser approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser
Copy link
Member

TahaTesser commented Apr 20, 2023

Need a second review from @HansMuller to land this.

@TahaTesser TahaTesser mentioned this pull request Apr 20, 2023
Closed
HansMuller
HansMuller approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
08f48a9 
…flutter#124743)
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
8c36f9e 
…flutter#124743)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
a131adb 
…flutter#124743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
0ca64d1 
…flutter#124743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
1acadfc 
…flutter#124743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
6f1fcb3 
…flutter#124743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
54b53ea 
…flutter#124743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
c9b6054 
…flutter#124743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
4cc46a7 
…flutter#124743)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
36b113c 
…flutter#124743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
0204466 
…flutter#124743)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
0c7bc2f Implement CheckmarkableChipAttributes on ChoiceChip (flutter/…
970dac1 
…flutter#124743)
@MoyinShabi
Copy link

MoyinShabi commented Jul 13, 2023

@9oya Hi, thanks a lot for this fix! But when do I get to use the showCheckMark property of the M3 ChoiceChip widget, please? I'm on the flutter sdk version 3.10.5 and the property still doesn't exist for the widget...

@TahaTesser
Copy link
Member

TahaTesser commented Jul 14, 2023

@9oya Hi, thanks a lot for this fix! But when do I get to use the showCheckMark property of the M3 ChoiceChip widget, please? I'm on the flutter sdk version 3.10.5 and the property still doesn't exist for the widget...

Hi! This is currently available on the beta channel. It should land in the stable channel during the next major release.

You can see a list of Flutter version tags assigned to this commit by clicking the commit above.

Screenshot 2023-07-14 at 11 07 46

Screenshot 2023-07-14 at 11 06 19

@MoyinShabi
Copy link

MoyinShabi commented Jul 14, 2023

Awesome, thank you!!

@9oya
Copy link
Contributor Author

9oya commented Jul 15, 2023

Thanks @TahaTesser :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When using Material 3, the ChoiceChip check mark cannot be hidden.

4 participants

@9oya @TahaTesser @MoyinShabi @HansMuller