Remove uses of deprecated test_api imports #124732
Conversation
Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files. Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`.
flutter-dashboard
bot
added
a: tests
| import 'dart:typed_data'; | ||
|
|
||
| import 'package:test_api/src/expect/async_matcher.dart'; // ignore: implementation_imports | ||
| import 'package:matcher/src/expect/async_matcher.dart'; // ignore: implementation_imports |
There was a problem hiding this comment.
For my own understanding, why is this one not part of the public API of package:matcher? Could it be? Seems like we are using it in a lot of places...
There was a problem hiding this comment.
For my own understanding, why is this one not part of the public API of package:matcher?
AsyncMatcher was originally a hack in package:test. It's not a very easy class to use, and it's behavior is contradictory to the rest of package:matcher.
Could it be?
Now that is has been moved into package:matcher it would be a little less strange to expose it. I'd still be a bit wary to do so, since we don't want to spend effort on things like improving the documentation and compatibility with AsyncMatcher.
I think a better use of time is to focus on the transition to package:checks where async checks are fully supported.
|
(I restarted all the failing checks, they were failing due to a pub outage) |
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Tool side LGTM
natebosch
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 124732, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
I created a CL with the required deps changes. Once it has an LGTM I'll add it in FRoB and it should fix Google testing. |
natebosch
added
the
autosubmit
|
@natebosch just following up to let you know Google testing seems to be stuck, updating the branch may kickstart it again? |
4 participants
Most of these imports were never appropriate. The
test_apipackage was never intended for use in_test.dartfiles.Where possible move imports to
matcher, otherwise move them totestorflutter_test.Leave uses of
test_apifromflutter_testlibrary code.