Revert "[framework] use shader tiling instead of repeated calls to drawImage" #124640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Apr 15, 2023
The pipeline blend component of flutter/flutter#124025 . This should also land alongside flutter/flutter#124640 which was necessary before we had completely optimized the image filters for texture inputs. Fixes flutter/flutter#121650 Fixes flutter/flutter#124025
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 16, 2023
flutter/flutter@00171b0...50171bb 2023-04-16 [email protected] Roll Flutter Engine from da0805a9cf03 to 4a998b73a2df (5 revisions) (flutter/flutter#124944) 2023-04-16 [email protected] Roll Flutter Engine from feb476b7b991 to da0805a9cf03 (4 revisions) (flutter/flutter#124933) 2023-04-15 [email protected] Roll Flutter Engine from ee66f0d6f2c9 to feb476b7b991 (2 revisions) (flutter/flutter#124929) 2023-04-15 [email protected] Revert "[framework] use shader tiling instead of repeated calls to drawImage" (flutter/flutter#124640) 2023-04-15 [email protected] [cupertino] improve cupertino picker performance by using at most one opacity layer (flutter/flutter#124719) 2023-04-15 [email protected] [flutter_tools] Remove `Version.unknown` (flutter/flutter#124771) 2023-04-15 [email protected] Roll Flutter Engine from 41c1ea9a8283 to ee66f0d6f2c9 (2 revisions) (flutter/flutter#124923) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…awImage" (flutter#124640) Reverts flutter#119495 We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter@00171b0...50171bb 2023-04-16 [email protected] Roll Flutter Engine from da0805a9cf03 to 4a998b73a2df (5 revisions) (flutter/flutter#124944) 2023-04-16 [email protected] Roll Flutter Engine from feb476b7b991 to da0805a9cf03 (4 revisions) (flutter/flutter#124933) 2023-04-15 [email protected] Roll Flutter Engine from ee66f0d6f2c9 to feb476b7b991 (2 revisions) (flutter/flutter#124929) 2023-04-15 [email protected] Revert "[framework] use shader tiling instead of repeated calls to drawImage" (flutter/flutter#124640) 2023-04-15 [email protected] [cupertino] improve cupertino picker performance by using at most one opacity layer (flutter/flutter#124719) 2023-04-15 [email protected] [flutter_tools] Remove `Version.unknown` (flutter/flutter#124771) 2023-04-15 [email protected] Roll Flutter Engine from 41c1ea9a8283 to ee66f0d6f2c9 (2 revisions) (flutter/flutter#124923) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #119495
We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...