Skip to content

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 11, 2023

Eliminate map that's redundant with enum values
Use enhanced enum and extention features

Eliminate map that's redundant with enum values
Use enhanced enum and extention features
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 11, 2023
@kevmoo kevmoo requested a review from eyebrowsoffire April 11, 2023 01:46
@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 11, 2023

PTAL @ditman

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Look at all those get foo => switch(this)..., damn! Sweet, sweet syntax sugar!

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit 895879c into master Apr 12, 2023
@auto-submit auto-submit bot deleted the web_enum_silly branch April 12, 2023 00:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
flutter_tools: Flutter Web CLI cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants