Implement "iterations" directive for customer tests #124541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us reduce the number of iterations for some customer tests that are known to be slow but that we've decided to accept anyway.
flutter-dashboard
bot
added
the
c: contributor-productivity
| fetch.add(line.substring(6)); | ||
| } else if (line.startsWith('update=')) { | ||
| update.add(Directory(line.substring(7))); | ||
| } else if (line.startsWith('iterations=')) { |
Contributor
There was a problem hiding this comment.
Will this now mean that this directive appearing will override the default value of 1 that gets used in flutter/flutter CI?
Contributor
Author
There was a problem hiding this comment.
no, see runner.dart (and run_tests.dart) below. It uses the lower of the two values.
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 124541, due to - The status or check suite Windows build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2023
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
Implement "iterations" directive for customer tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us reduce the number of iterations for some customer tests that are known to be slow but that we've decided to accept anyway.