Skip to content

Fix ShaderMask Example issue #124511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 11, 2023
Merged

Fix ShaderMask Example issue #124511

auto-submit merged 1 commit into from
Apr 11, 2023

Conversation

@adityathakurxd
Copy link
Contributor

@adityathakurxd adityathakurxd commented Apr 10, 2023 •
edited
Loading

Fixed the code example for the ShaderMask class to make the text look like it is on fire.
Example that makes the text look like it is on fire

Fixes: #124323

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@adityathakurxd
Fix ShaderMask Example issue
419eac8 
Documentation with wrong code - Flutter ShaderMask Class
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 10, 2023
@piedcipher
Copy link
Member

piedcipher commented Apr 10, 2023 •
edited
Loading

@adityathakurxd you could tick the last checkbox.

All existing and new tests are passing.

Edit: since bot didn't complaint about a missing test, you could tick this as well:

I added new tests to check the change I am making, or this PR is test-exempt.

Edit 2: If you would prefix the issue number with fixes it would close the issue automatically if pr is merged.

fixes: #issue-number

@adityathakurxd
Copy link
Contributor Author

adityathakurxd commented Apr 10, 2023

@adityathakurxd you could tick the last checkbox.

All existing and new tests are passing.

Thank you @piedcipher 🚀

werainkhatri
werainkhatri approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution!

this will need a second approval, will request for one.

LGTM

@werainkhatri
Copy link
Member

werainkhatri commented Apr 11, 2023

hey! could you add in the description of this PR, why was the color supposed to be set to white for this to work? if it's a non-obvious reason, we should add a comment in the doc code too.

@adityathakurxd
Copy link
Contributor Author

adityathakurxd commented Apr 11, 2023

Hi @werainkhatri, thank you for the review.

The video attached in the documentation of ShaderMask class uses the color white but the code sample isn't updated.

Screenshot 2023-04-11 at 12 35 13 PM

Not sure why. This issue is a documentation fix. There's another issue tracking this behavior #82617

@werainkhatri
Copy link
Member

werainkhatri commented Apr 11, 2023

oh, okay. thanks for finding and linking that here.

jonahwilliams
jonahwilliams approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@werainkhatri werainkhatri added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit c9f23b0 into flutter:master Apr 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2023
@engine-flutter-autoroll
c9f23b0 Fix ShaderMask Example issue (flutter/flutter#124511)
7074d52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
c9f23b0 Fix ShaderMask Example issue (flutter/flutter#124511)
eb28642
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@adityathakurxd @exaby73
Fix ShaderMask Example issue (flutter#124511)
e9c972d 
Fix ShaderMask Example issue
@HansMuller HansMuller mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werainkhatri werainkhatri werainkhatri approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation with wrong code - Flutter ShaderMask Class

4 participants

@adityathakurxd @piedcipher @werainkhatri @jonahwilliams