add tests for dominant bottom sheet in scaffold #124472

werainkhatri · 2023-04-09T10:06:27Z

while debugging #123882 found out that below lines were untested. although they'll change due to the issue above, but the tests will remain.

flutter/packages/flutter/lib/src/material/scaffold.dart

Lines 3169 to 3180 in e0045d0

    
           final double extentRemaining = 1.0 - notification.extent; 
        
           final ScaffoldState scaffold = Scaffold.of(context); 
        
           if (extentRemaining < _kBottomSheetDominatesPercentage) { 
        
             scaffold._floatingActionButtonVisibilityValue = extentRemaining * _kBottomSheetDominatesPercentage * 10; 
        
             scaffold.showBodyScrim(true,  math.max( 
        
               _kMinBottomSheetScrimOpacity, 
        
               _kMaxBottomSheetScrimOpacity - scaffold._floatingActionButtonVisibilityValue, 
        
             )); 
        
           } else { 
        
             scaffold._floatingActionButtonVisibilityValue = 1.0; 
        
             scaffold.showBodyScrim(false, 0.0); 
        
           }

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

Piinks

Hey @werainkhatri! Thanks for this! Is this behavior documented somewhere?

werainkhatri · 2023-04-26T17:52:55Z

Is this behavior documented somewhere?

i can't seem to find anything, but this was added 4 years ago (#21896), so idk what to make of it.

Piinks

Thanks for checking! Can you add mention of this behavior in the documentation then? It has surprised and confused some folks that this happens. Maybe we should mention it. :)

werainkhatri · 2023-05-01T18:38:36Z

It has surprised and confused some folks that this happens.

sure. just out of curiosity, was it surprising because it wasn't documented or it isn't expected? coz although it doesn't seem out of the box or wrong, we'll have to change this in order to fix #123882.

Piinks

was it surprising because it wasn't documented or it isn't expected?

#123882 mentions the shrinking is expected. I am not super familiar with this behavior, maybe it was part of the old spec? Not sure. :)

we'll have to change this in order to fix #123882

I am not sure of that either, since there isn't a fix for that issue yet. This could very well change, but I think it was a great idea to add tests that capture the current behavior, so we can understand how it may (or may not) be affected by another change. :)

packages/flutter/lib/src/material/scaffold.dart

Piinks

LGTM!

…ter#124472)

Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

) Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

…ter#124472)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 9, 2023

werainkhatri requested a review from Piinks April 19, 2023 00:02

Piinks reviewed Apr 24, 2023

View reviewed changes

Piinks reviewed May 1, 2023

View reviewed changes

werainkhatri requested a review from Piinks May 4, 2023 23:52

werainkhatri added 2 commits May 5, 2023 05:31

add tests for dominant bottom sheet in scaffold

2996e83

documents scaling of FAB and scrimming of the scaffold

efeef76

werainkhatri force-pushed the scaffold-test branch from ad12b94 to efeef76 Compare May 5, 2023 00:01

Piinks reviewed May 5, 2023

View reviewed changes

packages/flutter/lib/src/material/scaffold.dart Outdated Show resolved Hide resolved

Apply suggestions from code review

faef8b7

Piinks reviewed May 5, 2023

View reviewed changes

packages/flutter/lib/src/material/scaffold.dart Outdated Show resolved Hide resolved

Update packages/flutter/lib/src/material/scaffold.dart

e2cda4e

Piinks approved these changes May 5, 2023

View reviewed changes

Piinks added a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ documentation autosubmit Merge PR when tree becomes green via auto submit App labels May 5, 2023

auto-submit bot merged commit d5df458 into flutter:master May 5, 2023

engine-flutter-autoroll mentioned this pull request May 6, 2023

Manual roll Flutter from 0b657236cae4 to 43ac23b4c7b4 (30 revisions) flutter/packages#3922

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023

d5df458 add tests for dominant bottom sheet in scaffold (flutter/flut…

360388e

…ter#124472)

werainkhatri deleted the scaffold-test branch May 6, 2023 03:54

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

d5df458 add tests for dominant bottom sheet in scaffold (flutter/flut…

367c143

…ter#124472)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

d5df458 add tests for dominant bottom sheet in scaffold (flutter/flut…

8807b27

…ter#124472)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

d5df458 add tests for dominant bottom sheet in scaffold (flutter/flut…

ac92838

…ter#124472)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

d5df458 add tests for dominant bottom sheet in scaffold (flutter/flut…

9024794

…ter#124472)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add tests for dominant bottom sheet in scaffold #124472

add tests for dominant bottom sheet in scaffold #124472

Uh oh!

werainkhatri commented Apr 9, 2023 •

edited

Loading

Uh oh!

Piinks left a comment

Uh oh!

werainkhatri commented Apr 26, 2023

Uh oh!

Piinks left a comment

Uh oh!

werainkhatri commented May 1, 2023

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	final double extentRemaining = 1.0 - notification.extent;
	final ScaffoldState scaffold = Scaffold.of(context);
	if (extentRemaining < _kBottomSheetDominatesPercentage) {
	scaffold._floatingActionButtonVisibilityValue = extentRemaining * _kBottomSheetDominatesPercentage * 10;
	scaffold.showBodyScrim(true, math.max(
	_kMinBottomSheetScrimOpacity,
	_kMaxBottomSheetScrimOpacity - scaffold._floatingActionButtonVisibilityValue,
	));
	} else {
	scaffold._floatingActionButtonVisibilityValue = 1.0;
	scaffold.showBodyScrim(false, 0.0);
	}

add tests for dominant bottom sheet in scaffold #124472

add tests for dominant bottom sheet in scaffold #124472

Uh oh!

Conversation

werainkhatri commented Apr 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

werainkhatri commented Apr 26, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

werainkhatri commented May 1, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

werainkhatri commented Apr 9, 2023 •

edited

Loading