Force plugin transitive dependencies to an ARC compatible version #124349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
flutter-dashboard
bot
added
the
c: contributor-productivity
| return unless target.dependencies.any? { |dependency| dependency.name == 'FlutterMacOS' } | ||
|
|
||
| # [target.deployment_target] is a [String] formatted as "10.8". | ||
| deployment_target_major, deployment_target_minor = target.deployment_target.match(/(\d+).?(\d*)/).captures |
Contributor
There was a problem hiding this comment.
unrelated, but we should escape the . here, right? we can do it later if you want to hotfix this.
Member
Author
There was a problem hiding this comment.
Yes, human regex debugger. I'll do that in master though as you say since I do want to hotfix this.
| build_configuration.build_settings['MACOSX_DEPLOYMENT_TARGET'] = '10.11' if force_to_arc_supported_min | ||
|
|
||
| # Skip other updates if it's not a Flutter plugin (transitive dependency). | ||
| next unless target.dependencies.any? { |dependency| dependency.name == 'FlutterMacOS' } |
Contributor
There was a problem hiding this comment.
what if it has dependencies that have dependencies on FlutterMacOS?
Member
Author
There was a problem hiding this comment.
They would each be processed separately in this loop. The ones that depend on Flutter (Flutter plugins) will continue no matter if it's a dependency of something else or not, but the ones that don't (non-Flutter plugin transitive dependencies) won't.
Did I understand the question?
Contributor
There was a problem hiding this comment.
Ahh, makes sense!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 8, 2023
jmagman
added a commit
to jmagman/flutter
that referenced
this pull request
Apr 10, 2023
…utter#124349) Force plugin transitive dependencies to an ARC compatible version
itsjustkevin
pushed a commit
that referenced
this pull request
Apr 10, 2023
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…utter#124349) Force plugin transitive dependencies to an ARC compatible version
stuartmorgan-g
pushed a commit
to stuartmorgan-g/flutter
that referenced
this pull request
May 11, 2023
…utter#124349) Force plugin transitive dependencies to an ARC compatible version
XilaiZhang
pushed a commit
that referenced
this pull request
May 15, 2023
#126548) Cherry-pick #124349 onto stable (3.10). CP request at #126549 Co-authored-by: Jenn Magder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 14.3 (released March 30, 2023) stopped building automatic reference counted (ARC) code targeting < iOS 9 or < macOS 10.11 by removing a
libarclite_*library from the toolchain that was needed to link for these older targets.Flutter was already forcing Flutter plugins to the same minimum version as the app, but wasn't doing so for the plugins's transitive dependencies. In particular, some Firebase plugins depend on pods targeting lower versions.
Force transitive dependencies to a minimum version of at least iOS 9 or macOS 10.11.
https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_test_ios/16683
https://ci.chromium.org/p/flutter/builders/try/Mac%20plugin_test_macos/3136
Fixes #124340
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.