Skip to content

ExpansionTile audit #124281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Apr 10, 2023
Merged

ExpansionTile audit #124281

auto-submit merged 4 commits into from
Apr 10, 2023

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 5, 2023 •
edited
Loading

fixes #121636
fixes #120650
fixes #74963

This is basically the same pr as #121699

The radio button fix will be in the engine

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 5, 2023
@chunhtai chunhtai marked this pull request as draft April 5, 2023 23:05
@chunhtai chunhtai marked this pull request as ready for review April 6, 2023 19:14
@chunhtai chunhtai changed the title ExpnasionTile/Radio/RadioListTile audit ExpansionTile audit Apr 6, 2023
TahaTesser
TahaTesser approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gspencergoog
gspencergoog approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 10, 2023
@auto-submit auto-submit bot merged commit f662f2e into flutter:master Apr 10, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2023
@engine-flutter-autoroll
f662f2e ExpansionTile audit (flutter/flutter#124281)
363b2a4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2023
@engine-flutter-autoroll
f662f2e ExpansionTile audit (flutter/flutter#124281)
7e8ac37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2023
@engine-flutter-autoroll
f662f2e ExpansionTile audit (flutter/flutter#124281)
5c0892e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
f662f2e ExpansionTile audit (flutter/flutter#124281)
2e72a3a
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@chunhtai @exaby73
ExpansionTile audit (flutter#124281)
f502331 
ExpansionTile audit
@HansMuller HansMuller mentioned this pull request Apr 20, 2023
Closed
@TahaTesser TahaTesser mentioned this pull request Aug 10, 2023
Closed
2 tasks
@yjbanov yjbanov mentioned this pull request Mar 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

3 participants

@chunhtai @gspencergoog @TahaTesser