Skip to content

Disableable ContextMenuButtonItems #124253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 13 commits into from
Apr 19, 2023
Merged

Disableable ContextMenuButtonItems #124253

auto-submit merged 13 commits into from
Apr 19, 2023

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Apr 5, 2023

Fixes #124247

Native Flutter before Flutter after
Screenshot 2023-04-05 at 9 26 16 AM Screenshot 2023-04-05 at 11 18 01 AM Screenshot 2023-04-05 at 11 17 36 AM

Also, it's now possible for anyone to create disabled buttons like this by setting ContextMenuButtonItem.onPressed to null.

@justinmc justinmc self-assigned this Apr 5, 2023
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 5, 2023
@justinmc justinmc changed the title Allow disabled ContextMenuButtonItems, and make 'No replacements foun… Disableable ContextMenuButtonItems Apr 5, 2023
@justinmc justinmc requested a review from camsim99 April 5, 2023 19:04
@justinmc justinmc force-pushed the no-replacements-found-disabled branch from b6caff7 to b56f422 Compare April 12, 2023 22:08
@justinmc justinmc marked this pull request as ready for review April 12, 2023 22:08
camsim99
camsim99 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/flutter/test/cupertino/spell_check_suggestions_toolbar_test.dart Outdated
void main() {
TestWidgetsFlutterBinding.ensureInitialized();

testWidgets('buildButtonItems builds a "No Replacements Found" button when no suggestions', (WidgetTester tester) async {
Copy link
Contributor

@camsim99 camsim99 Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this test!

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023
@auto-submit auto-submit bot merged commit 3128df8 into flutter:master Apr 19, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2023
@engine-flutter-autoroll
3128df8 Disableable ContextMenuButtonItems (flutter/flutter#124253)
2c024b1
@justinmc justinmc deleted the no-replacements-found-disabled branch April 19, 2023 16:17
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 19, 2023
@engine-flutter-autoroll
Roll Flutter from 42fb0b2 to 3476b96 (20 revisions) (#3760)
88591be 
flutter/flutter@42fb0b2...3476b96

2023-04-19 [email protected] Update helper message for `--suppress-analytics` (flutter/flutter#124810)
2023-04-19 [email protected] Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) (flutter/flutter#125097)
2023-04-19 [email protected] Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) (flutter/flutter#125094)
2023-04-19 [email protected] Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) (flutter/flutter#125078)
2023-04-19 [email protected] Disableable ContextMenuButtonItems (flutter/flutter#124253)
2023-04-18 [email protected] Adaptive alert dialog (flutter/flutter#124336)
2023-04-18 [email protected] Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (flutter/flutter#125069)
2023-04-18 [email protected] Remove package:js/dart:js_interop conflicts (flutter/flutter#124879)
2023-04-18 [email protected] Remove double.fromEnvironment from dart-define doc (flutter/flutter#124102)
2023-04-18 [email protected] Update to add Kim Jiun to `AUTHORS` (flutter/flutter#125026)
2023-04-18 [email protected] Add controller argument to SubmenuButton (flutter/flutter#125000)
2023-04-18 [email protected] Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (flutter/flutter#125060)
2023-04-18 [email protected] Limit the number of Material spell check suggestions to 3 (flutter/flutter#124899)
2023-04-18 [email protected] Remove impeller testowners (flutter/flutter#125056)
2023-04-18 [email protected] [web] - Clean up skipped tests (flutter/flutter#124981)
2023-04-18 [email protected] Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (flutter/flutter#125057)
2023-04-18 [email protected] Remove unused getRootRenderObject and getSelectedRenderObject service extensions (flutter/flutter#124805)
2023-04-18 [email protected] l10n.yaml's nullable-getter option should default to true (flutter/flutter#124353)
2023-04-18 [email protected] Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (flutter/flutter#125053)
2023-04-18 [email protected] Add vmservice for android build options (flutter/flutter#123034)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Apr 20, 2023
Closed
8 tasks
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Closed
8 tasks
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Closed
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from 42fb0b2 to 3476b96 (20 revisions) (flutter#3760)
d5f3329 
flutter/flutter@42fb0b2...3476b96

2023-04-19 [email protected] Update helper message for `--suppress-analytics` (flutter/flutter#124810)
2023-04-19 [email protected] Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) (flutter/flutter#125097)
2023-04-19 [email protected] Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) (flutter/flutter#125094)
2023-04-19 [email protected] Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) (flutter/flutter#125078)
2023-04-19 [email protected] Disableable ContextMenuButtonItems (flutter/flutter#124253)
2023-04-18 [email protected] Adaptive alert dialog (flutter/flutter#124336)
2023-04-18 [email protected] Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (flutter/flutter#125069)
2023-04-18 [email protected] Remove package:js/dart:js_interop conflicts (flutter/flutter#124879)
2023-04-18 [email protected] Remove double.fromEnvironment from dart-define doc (flutter/flutter#124102)
2023-04-18 [email protected] Update to add Kim Jiun to `AUTHORS` (flutter/flutter#125026)
2023-04-18 [email protected] Add controller argument to SubmenuButton (flutter/flutter#125000)
2023-04-18 [email protected] Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (flutter/flutter#125060)
2023-04-18 [email protected] Limit the number of Material spell check suggestions to 3 (flutter/flutter#124899)
2023-04-18 [email protected] Remove impeller testowners (flutter/flutter#125056)
2023-04-18 [email protected] [web] - Clean up skipped tests (flutter/flutter#124981)
2023-04-18 [email protected] Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (flutter/flutter#125057)
2023-04-18 [email protected] Remove unused getRootRenderObject and getSelectedRenderObject service extensions (flutter/flutter#124805)
2023-04-18 [email protected] l10n.yaml's nullable-getter option should default to true (flutter/flutter#124353)
2023-04-18 [email protected] Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (flutter/flutter#125053)
2023-04-18 [email protected] Add vmservice for android build options (flutter/flutter#123034)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 camsim99 approved these changes

Assignees

@justinmc justinmc

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

It should be possible to create disabled buttons with ContextMenuButtonItem

2 participants

@justinmc @camsim99