Add tools test for buildWeb compilation #124179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
tool
jmagman
commented
Apr 5, 2023
|
|
||
| final ProjectMigration migration = ProjectMigration(migrators); | ||
| migration.run(); | ||
| Future<void> buildWeb( |
Member
Author
There was a problem hiding this comment.
Most of this method is whitespace changes, which you can optionally ignore in the GitHub UI for this change, if you want:
jmagman
commented
Apr 5, 2023
| flutterVersion: flutterVersion, | ||
| fileSystem: fileSystem, | ||
| ); | ||
| await webBuilder.buildWeb( |
Member
Author
There was a problem hiding this comment.
This covers only one permutation of these parameters, but hopefully this gives an example that can be expanded on by the web team in the future.
eyebrowsoffire
approved these changes
Apr 5, 2023
Contributor
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
This is awesome! Thank you!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2023
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
Add tools test for buildWeb compilation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some baseline web compilation tool tests to make changes like #124165 easier to test.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.