[web] Skip temporarily broken test #124160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: examples
htoor3
commented
Apr 4, 2023
|
|
||
| final WebElement? fltSemantics = await driver.webDriver.execute( | ||
| 'return document.querySelector("flt-glass-pane")?.shadowRoot.querySelector("flt-semantics")', | ||
| 'return document.querySelector("flt-semantics")', |
Contributor
Author
There was a problem hiding this comment.
With the DOM structure change, we can query the flt-semantics from the document directly, instead of having to grab the shadowRoot first.
mdebbar
approved these changes
Apr 4, 2023
Member
|
Here's info about the skip error: |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 6, 2023
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
[web] Skip temporarily broken test
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web test will be broken after flutter/engine#40904 merges, so we need to disable this first. Will need to be re-enabled post-merge once the engine rolls.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.