Skip to content

Make flutter_adapter_test more resilient to pub output #124139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 4, 2023
Merged

Make flutter_adapter_test more resilient to pub output #124139

auto-submit merged 1 commit into from
Apr 4, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Apr 4, 2023

Makes test more resilient by allowing extra lines instead of exact matching all lines.

Fixes #124128.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 4, 2023
jonahwilliams
jonahwilliams approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@chunhtai chunhtai mentioned this pull request Apr 4, 2023
Merged
8 tasks
jmagman
jmagman approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being proactive about fixing!

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit auto-submit bot merged commit d6593de into flutter:master Apr 4, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
d6593de Make flutter_adapter_test more resilient to pub output (flutt…
b7388cd 
…er/flutter#124139)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
d6593de Make flutter_adapter_test more resilient to pub output (flutt…
4a8f2ec 
…er/flutter#124139)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@vashworth @exaby73
Make flutter_adapter_test more resilient to pub output (flutter#124139)
56f9fd6 
Make flutter_adapter_test more resilient to pub output
@DanTup DanTup mentioned this pull request May 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d6593de Make flutter_adapter_test more resilient to pub output (flutt…
f64c54a 
…er/flutter#124139)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d6593de Make flutter_adapter_test more resilient to pub output (flutt…
cef619c 
…er/flutter#124139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flakes] test/integration.shard/debug_adapter/flutter_adapter_test.dart should be resilient to pub output

3 participants

@vashworth @jmagman @jonahwilliams