Remove double.fromEnvironment from dart-define doc #124102

Mastersam07 · 2023-04-04T07:11:46Z

Remove double.fromEnvironment from dart-define doc.

The current dart-define docs reads:

Additional key-value pairs that will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and
double.fromEnvironment constructors.

while dart-define-from-file reads:

The path of a json format file where flutter define a global constant pool. 
Json entry will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, 
and double.fromEnvironment constructors; the key and field are json values

However, there is no fromEnvironment constructor for double. The aim of this PR is to address this by removing double.fromEnvironment from help docs as stated in

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

google-cla · 2023-04-04T07:11:53Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

christopherfujino

LGTM

christopherfujino · 2023-04-06T23:21:01Z

Test failure looks like a flake, re-triggered

flutter-dashboard · 2023-04-12T08:55:03Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

andrewkolos

LGTM with nit

packages/flutter_tools/lib/src/runner/flutter_command.dart

preserve serial/oxford comma Co-authored-by: Andrew Kolos <[email protected]>

…lutter#124102)

flutter/flutter@42fb0b2...3476b96 2023-04-19 [email protected] Update helper message for `--suppress-analytics` (flutter/flutter#124810) 2023-04-19 [email protected] Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) (flutter/flutter#125097) 2023-04-19 [email protected] Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) (flutter/flutter#125094) 2023-04-19 [email protected] Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) (flutter/flutter#125078) 2023-04-19 [email protected] Disableable ContextMenuButtonItems (flutter/flutter#124253) 2023-04-18 [email protected] Adaptive alert dialog (flutter/flutter#124336) 2023-04-18 [email protected] Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (flutter/flutter#125069) 2023-04-18 [email protected] Remove package:js/dart:js_interop conflicts (flutter/flutter#124879) 2023-04-18 [email protected] Remove double.fromEnvironment from dart-define doc (flutter/flutter#124102) 2023-04-18 [email protected] Update to add Kim Jiun to `AUTHORS` (flutter/flutter#125026) 2023-04-18 [email protected] Add controller argument to SubmenuButton (flutter/flutter#125000) 2023-04-18 [email protected] Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (flutter/flutter#125060) 2023-04-18 [email protected] Limit the number of Material spell check suggestions to 3 (flutter/flutter#124899) 2023-04-18 [email protected] Remove impeller testowners (flutter/flutter#125056) 2023-04-18 [email protected] [web] - Clean up skipped tests (flutter/flutter#124981) 2023-04-18 [email protected] Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (flutter/flutter#125057) 2023-04-18 [email protected] Remove unused getRootRenderObject and getSelectedRenderObject service extensions (flutter/flutter#124805) 2023-04-18 [email protected] l10n.yaml's nullable-getter option should default to true (flutter/flutter#124353) 2023-04-18 [email protected] Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (flutter/flutter#125053) 2023-04-18 [email protected] Add vmservice for android build options (flutter/flutter#123034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 4, 2023

Mastersam07 marked this pull request as ready for review April 4, 2023 07:33

Mastersam07 added 2 commits April 4, 2023 12:59

remove double.fromEnvironment from dart-define doc

699ce5a

Merge branch 'master' into adjust-dart-define-help-doc

473f991

christopherfujino approved these changes Apr 6, 2023

View reviewed changes

Merge branch 'master' into adjust-dart-define-help-doc

e4ae45c

Merge branch 'master' into adjust-dart-define-help-doc

d80b38a

christopherfujino requested a review from andrewkolos April 13, 2023 20:54

andrewkolos approved these changes Apr 13, 2023

View reviewed changes

packages/flutter_tools/lib/src/runner/flutter_command.dart Outdated Show resolved Hide resolved

Mastersam07 and others added 2 commits April 14, 2023 09:42

preserve serial/oxford comma

1d4191a

preserve serial/oxford comma Co-authored-by: Andrew Kolos <[email protected]>

Merge branch 'master' into adjust-dart-define-help-doc

1f4f059

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023

auto-submit bot merged commit 81c3bc5 into flutter:master Apr 18, 2023

engine-flutter-autoroll mentioned this pull request Apr 19, 2023

Roll Flutter from 42fb0b23139c to 3476b966524f (20 revisions) flutter/packages#3760

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2023

81c3bc5 Remove double.fromEnvironment from dart-define doc (flutter/f…

8c07453

…lutter#124102)

This was referenced Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

[integration_test] add support for agp8.0 #125310

Closed

Test AGP 8.0 using java 17 #125323

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove double.fromEnvironment from dart-define doc #124102

Remove double.fromEnvironment from dart-define doc #124102

Uh oh!

Mastersam07 commented Apr 4, 2023 •

edited

Loading

Uh oh!

google-cla bot commented Apr 4, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

christopherfujino commented Apr 6, 2023

Uh oh!

flutter-dashboard bot commented Apr 12, 2023

Uh oh!

andrewkolos left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove double.fromEnvironment from dart-define doc #124102

Remove double.fromEnvironment from dart-define doc #124102

Uh oh!

Conversation

Mastersam07 commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla bot commented Apr 4, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Apr 6, 2023

Uh oh!

flutter-dashboard bot commented Apr 12, 2023

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mastersam07 commented Apr 4, 2023 •

edited

Loading