Rename Sample classes #124080
Merged
Rename Sample classes #124080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: animation
gspencergoog
force-pushed
the
fix_example_class_names
branch
from
97b8f69 to
82a6f27
Compare
flutter-dashboard
bot
added
the
framework
loic-sharma
reviewed
Apr 4, 2023
loic-sharma
reviewed
Apr 4, 2023
loic-sharma
reviewed
Apr 4, 2023
examples/api/lib/material/navigation_drawer/navigation_drawer.0.dart
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Apr 4, 2023
loic-sharma
reviewed
Apr 4, 2023
loic-sharma
reviewed
Apr 4, 2023
examples/api/lib/widgets/editable_text/editable_text.on_content_inserted.0.dart
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Apr 4, 2023
loic-sharma
approved these changes
Apr 4, 2023
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
Thanks for going above and beyond! 🥇
gspencergoog
force-pushed
the
fix_example_class_names
branch
from
82a6f27 to
97a46eb
Compare
gspencergoog
force-pushed
the
fix_example_class_names
branch
from
97a46eb to
9a84056
Compare
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 5, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
Rename Sample classes
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the names of example classes so that
MyApp,_MyAppState,MyStatefulWidget,_MyStatefulWidgetState, andMyStatelessWidgetbecome class names that match the name of the example.It also fixes all the places where we had a comment like this:
// Flutter code sample for [SomeWidget].and converts it to a doc comment like so:
/// Flutter code sample for [SomeWidget].and moves it below the first import statement (to avoid triggering a lint).
This is so that examples viewed in an IDE have an active link back to the class they are meant to be showing an example of.
I also eliminated a bunch of places where we set the title on
MaterialApp, and moved the const string for titles that are set on anAppBarinto theAppBardeclaration itself, and renamed any titles that were just "Flutter App Sample" to be more specific to the sample.The first commit in the PR contains some minor fixes for examples that didn't conform to the naming convention. The second PR contains the mechanical renames of the example widget classes.
Tests