Skip to content

Add readlink -f flag to CocoaPods script to workaround Xcode 14.3 issue #124079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsjustkevin merged 1 commit into from
Apr 4, 2023
Merged

Add readlink -f flag to CocoaPods script to workaround Xcode 14.3 issue #124079

itsjustkevin merged 1 commit into from
Apr 4, 2023
+223 −0

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 4, 2023 •
edited
Loading

Cherry-pick #124062 onto stable.

CP request at #124081

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Apr 4, 2023
@jmagman jmagman self-assigned this Apr 4, 2023
@jmagman jmagman mentioned this pull request Apr 4, 2023
Closed
christopherfujino
christopherfujino approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin merged commit 4b12645 into flutter:flutter-3.7-candidate.1 Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
4b1264501 Add readlink -f flag to CocoaPods script to workaround Xcod…
7433336 
…e 14.3 issue (flutter/flutter#124079)
@jmagman jmagman deleted the cp-readlink branch April 6, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth Awaiting requested review from vashworth

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @itsjustkevin