[flutter_tools] Remove --no-sound-null-safety #4 #124039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
framework
christopherfujino
force-pushed
the
remove-no-sound-null-safety-4
branch
from
0e8ffd0 to
030d802
Compare
CaseyHillers
approved these changes
Apr 4, 2023
Contributor
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
LGTM - Thank you for working on this!
This comment was marked as outdated.
This comment was marked as outdated.
… explicitly passed
christopherfujino
force-pushed
the
remove-no-sound-null-safety-4
branch
from
0842c7f to
8acbfd7
Compare
Contributor
|
Merging. Google Testing is having issues overriding the status. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 5, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
Re-land of flutter#123297 without any of the commits at the end attempting to fix customer-testing. Fixes flutter#118810
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-land of #123297 without any of the commits at the end attempting to fix customer-testing.
Fixes #118810