[ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget #123971

piedcipher · 2023-04-02T16:31:16Z

Adds materialGapSize property to ExpansionPanelList widget.

`materialGapSize: 0`	`materialGapSize: 16` (default)	`materialGapSize: 30`

Fixes: #118167

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-04-02T16:31:20Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

werainkhatri

the images are quite helpful, thanks for that!

left a few comments.

packages/flutter/lib/src/material/expansion_panel.dart

packages/flutter/test/material/expansion_panel_test.dart

packages/flutter/lib/src/material/expansion_panel.dart

piedcipher · 2023-04-02T18:44:54Z

thanks a lot for the detailed review, I'll work on the review comments. 💙

piedcipher · 2023-04-24T05:14:54Z

I've resolved review comments. Could you please review it again?

werainkhatri

thanks for another great contribution!

packages/flutter/test/material/expansion_panel_test.dart

piedcipher

oh I didn't realise this mistake! Thanks for fixing

piedcipher · 2023-05-05T21:02:59Z

@werainkhatri google testing is still yellow.

werainkhatri · 2023-05-06T04:00:00Z

@werainkhatri google testing is still yellow

it's fine. yellow is not bad or wrong, it's expected. anyway you have to wait for a second review. just be patient. we'll handle it and let you know if there is anything you need to do.

piedcipher · 2023-05-06T07:10:26Z

@werainkhatri google testing is still yellow

it's fine. yellow is not bad or wrong, it's expected. anyway you have to wait for a second review. just be patient. we'll handle it and let you know if there is anything you need to do.

Sure! and I'm not in any hurry, it's a month old pr and I'm pretty patient and not in any hurry. Take your time.

Hixie

Thanks for the contribution!

…nPanelList Widget (flutter/flutter#123971)

flutter/flutter@43ac23b...4ed1c92 2023-05-08 [email protected] Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (flutter/flutter#126265) 2023-05-08 [email protected] Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (flutter/flutter#125995) 2023-05-08 [email protected] Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (flutter/flutter#126262) 2023-05-08 [email protected] Fix leaks (flutter/flutter#126144) 2023-05-08 [email protected] Update packages (flutter/flutter#126140) 2023-05-06 [email protected] [ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (flutter/flutter#123971) 2023-05-06 [email protected] Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (flutter/flutter#126199) 2023-05-06 [email protected] Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (flutter/flutter#126198) 2023-05-06 [email protected] Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (flutter/flutter#126195) 2023-05-06 [email protected] [ios] fix hold and drag spacebar does not move cursor when obscureTexâ�¦ (flutter/flutter#122383) 2023-05-06 [email protected] Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (flutter/flutter#126192) 2023-05-06 [email protected] Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) (flutter/flutter#126190) 2023-05-06 [email protected] Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) (flutter/flutter#126188) 2023-05-06 [email protected] â�¨ Add `rect` argument to `_ArcPaintPredicate` for tests (flutter/flutter#125953) 2023-05-06 [email protected] Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) (flutter/flutter#126187) 2023-05-06 [email protected] Add Windows and Linux support to the 'layers' example (flutter/flutter#126105) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…nPanelList Widget (flutter/flutter#123971)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 2, 2023

werainkhatri reviewed Apr 2, 2023

View reviewed changes

piedcipher marked this pull request as draft April 7, 2023 22:04

piedcipher marked this pull request as ready for review April 12, 2023 20:22

piedcipher requested a review from werainkhatri April 12, 2023 20:31

werainkhatri approved these changes Apr 26, 2023

View reviewed changes

packages/flutter/test/material/expansion_panel_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/expansion_panel_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/expansion_panel_test.dart Outdated Show resolved Hide resolved

piedcipher commented Apr 26, 2023

View reviewed changes

piedcipher and others added 9 commits May 4, 2023 23:25

add materialGapSize property in ExpansionPanelList

8ff7b60

add widget-tests for materialGapSize

5c5ec0b

fix review comments

c4b3fb6

fix review comment

3c2c0cd

add better widget-test

ddd71cb

add widget-test

e0b47e3

add better code comment

f443dc9

add code-comment

99c400d

minor test fixes

ed0e2de

Hixie approved these changes May 6, 2023

View reviewed changes

Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2023

auto-submit bot merged commit 835b892 into flutter:master May 6, 2023

piedcipher deleted the enhancement/expansion_panel_list_mgsize branch May 6, 2023 21:09

engine-flutter-autoroll mentioned this pull request May 7, 2023

Roll Flutter from 43ac23b4c7b4 to 835b892d7fbe (11 revisions) flutter/packages#3928

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2023

835b892 [ExpansionPanelList] add materialGapSize property in Expansio…

a38c834

…nPanelList Widget (flutter/flutter#123971)

engine-flutter-autoroll mentioned this pull request May 7, 2023

Roll Flutter from 43ac23b4c7b4 to 835b892d7fbe (11 revisions) flutter/packages#3929

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2023

835b892 [ExpansionPanelList] add materialGapSize property in Expansio…

4951add

…nPanelList Widget (flutter/flutter#123971)

engine-flutter-autoroll mentioned this pull request May 8, 2023

Roll Flutter from 43ac23b4c7b4 to 4ed1c9230310 (16 revisions) flutter/packages#3942

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2023

835b892 [ExpansionPanelList] add materialGapSize property in Expansio…

d401ec0

…nPanelList Widget (flutter/flutter#123971)

HansMuller mentioned this pull request May 12, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

835b892 [ExpansionPanelList] add materialGapSize property in Expansio…

02af133

…nPanelList Widget (flutter/flutter#123971)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

835b892 [ExpansionPanelList] add materialGapSize property in Expansio…

695a03e

…nPanelList Widget (flutter/flutter#123971)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

835b892 [ExpansionPanelList] add materialGapSize property in Expansio…

1af4c4d

…nPanelList Widget (flutter/flutter#123971)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

835b892 [ExpansionPanelList] add materialGapSize property in Expansio…

83b1a55

…nPanelList Widget (flutter/flutter#123971)

[ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget #123971

[ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget #123971

Uh oh!

Conversation

piedcipher commented Apr 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Apr 2, 2023

Uh oh!

werainkhatri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

piedcipher commented Apr 2, 2023

Uh oh!

piedcipher commented Apr 24, 2023

Uh oh!

werainkhatri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

piedcipher left a comment

Choose a reason for hiding this comment

Uh oh!

piedcipher commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

werainkhatri commented May 6, 2023

Uh oh!

piedcipher commented May 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hixie left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

piedcipher commented Apr 2, 2023 •

edited

Loading

piedcipher commented May 5, 2023 •

edited

Loading

piedcipher commented May 6, 2023 •

edited

Loading