Skip to content

Conversation

@fluttergithubbot
Copy link
Contributor

This PR was generated by flutter update-packages --force-upgrade.

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App labels Mar 31, 2023
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. team: flakes c: tech-debt Technical debt, code quality, testing, etc. labels Mar 31, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 31, 2023

auto label is removed for flutter/flutter, pr: 123899, due to This PR has not met approval requirements for merging. You have project association MEMBER and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 31, 2023

auto label is removed for flutter/flutter, pr: 123899, due to Validations Fail.

@goderbauer
Copy link
Member

FYI @natebosch Here's the new PR opened by the bot.

@natebosch
Copy link
Contributor

natebosch commented Apr 1, 2023

The failures in customer_tests are expected - they are the flutter_reactive_ble package with a dependency that blocks the latest analyzer. Details in #123350 (comment)

I'm not sure what is happening in the framework_tests failure. It may be a flake? It looks like the same test case passes on flutter test infrastructure, but fails on cirrus.

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20framework_tests_misc/34905/overview
https://cirrus-ci.com/task/5181030374572032

In any case, nothing looks actionable by me. I'm currently waiting the required 72 hours since the email I sent yesterday to the flutter_reactive_ble owners. @goderbauer - will you be able to land this on Monday?

@zanderso
Copy link
Member

zanderso commented Apr 3, 2023

I don't see a change in flutter/tests and the flutter_reactive_ble tests are still running, but Elias triggered an update here (#124015) as part of bringing in a new package, and the customer tests are passing there. Does anyone know what changed over the weekend? In any case, I'll hit the "Update branch" button on this PR to bring it up to head and re-trigger the presubs.

@zanderso zanderso force-pushed the packages-autoroller-branch-91 branch from 2545ef5 to a1e5232 Compare April 3, 2023 15:06
@christopherfujino
Copy link
Contributor

I don't see a change in flutter/tests and the flutter_reactive_ble tests are still running, but Elias triggered an update here (#124015) as part of bringing in a new package, and the customer tests are passing there. Does anyone know what changed over the weekend? In any case, I'll hit the "Update branch" button on this PR to bring it up to head and re-trigger the presubs.

No idea how this got fixed, but we're all green so I guess I won't complain?

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 3, 2023

auto label is removed for flutter/flutter, pr: 123899, due to This PR has not met approval requirements for merging. You have project association MEMBER and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 3, 2023

auto label is removed for flutter/flutter, pr: 123899, due to Validations Fail.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit auto-submit bot merged commit 0046a25 into flutter:master Apr 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2023
@goderbauer
Copy link
Member

goderbauer commented Apr 3, 2023

No idea how this got fixed, but we're all green so I guess I won't complain?

Looks like a new version of dart_functional_data was released over the weekend and picked up by flutter_reactive_ble. The new version (1.1.5) is loosening the version requirements on the analyzer making it compatible with the analyzer version that test_api wants.

@natebosch Thanks for reaching out to the package maintainers to get this resolved! 🥳

@christopherfujino
Copy link
Contributor

Thanks @goderbauer and @natebosch for taking care of this while I was out!

@natebosch
Copy link
Contributor

Does anyone know what changed over the weekend?

https://pub.dev/packages/functional_data_generator/versions/1.1.5

The functional_data_generator package published a new version with an expanded analyzer compatibility. It looks like they did this from a local copy and have not updated github yet.

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants