SemanticsFlag/SemanticsAction cleanup (part 2)
#123817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
bernaferrari
changed the title
SemanticsFlag/SemanticsAction enum migration (part 2)
6 tasks
Contributor
Author
|
Do we need to make the analyzer pass? It fails because the property is deprecated, which is what we want. cc @goderbauer |
Member
|
Yes! You'll have to add |
bernaferrari
force-pushed
the
Semantics-part2
branch
2 times, most recently
from
38ac2e6 to
34a7409
Compare
Contributor
Author
|
Here it goes. |
Contributor
Author
|
How Google testing failed? I didn't think this was possible.. There are zero changes here. |
Member
|
It probably failed because the engine change this needs hasn’t rolled into Google yet. I’ll verify that tomorrow and let you know. |
bernaferrari
force-pushed
the
Semantics-part2
branch
from
34a7409 to
9293202
Compare
Member
|
@chunhtai can you give this a secondary review? |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
8 tasks
bernaferrari
changed the title
SemanticsFlag/SemanticsAction enum migration (part 2)SemanticsFlag/SemanticsAction cleanup (part 2)
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…3817) `SemanticsFlag`/`SemanticsAction` enum migration (part 2)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #123346
Migrate their usages into temporary properties.