Skip to content

Add adaptive constructor to Radio and RadioListTile #123816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 4, 2023
Merged

Add adaptive constructor to Radio and RadioListTile #123816

auto-submit merged 2 commits into from
Apr 4, 2023

Conversation

@MitchellGoodwin
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin commented Mar 30, 2023 •
edited
Loading

Fixes #102809. Adds an adaptive constructor to the Radio and RadioListTile widgets.

Screenshot 2023-03-30 at 1 46 30 PM

Screenshot 2023-03-30 at 1 46 15 PM

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 30, 2023
@MitchellGoodwin MitchellGoodwin marked this pull request as ready for review March 30, 2023 22:08
QuncCccccc
QuncCccccc approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:) !

packages/flutter/test/material/radio_list_tile_test.dart Outdated
Copy link
Contributor

@QuncCccccc QuncCccccc Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we don't need this StateBuilder because there's no state change?

packages/flutter/test/material/radio_test.dart Outdated
Copy link
Contributor

@QuncCccccc QuncCccccc Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:)

@MitchellGoodwin MitchellGoodwin removed the request for review from christopherfujino April 4, 2023 16:30
@MitchellGoodwin MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit auto-submit bot merged commit c8a3dba into flutter:master Apr 4, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
c8a3dba Add adaptive constructor to Radio and RadioListTile (flutter/…
894f8ba 
…flutter#123816)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
@engine-flutter-autoroll
c8a3dba Add adaptive constructor to Radio and RadioListTile (flutter/…
44ce13e 
…flutter#123816)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
@HansMuller HansMuller mentioned this pull request Apr 7, 2023
Closed
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@MitchellGoodwin @exaby73
Add adaptive constructor to Radio and RadioListTile (flutter#123816)
72a6e2a 
Add adaptive constructor to Radio and RadioListTile
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c8a3dba Add adaptive constructor to Radio and RadioListTile (flutter/…
e909375 
…flutter#123816)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c8a3dba Add adaptive constructor to Radio and RadioListTile (flutter/…
26fccd2 
…flutter#123816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add .adaptive constructor for single-selection

2 participants

@MitchellGoodwin @QuncCccccc