-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix state leak in rendering/editable_test (framework shuffle-all 2/n) #123806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For render objects with the same depth, [paint] gets called in the order that [markNeedsPaint] was called, which is not necessarily the visual paint order. So having a test check the order of [paint] calls is brittle. Here, it was breaking when an `editable.foregroundPainter = null`, intended to clean up a previous test, caused a [markNeedsPaint] on the composite foreground painter before the test could cause a [markNeedsPaint] on the background. Instead, follow the pattern of the neighboring tests and use the `paints` matcher. For debugging this it was useful to have a toString on this test painter class, so add that too.
LongCatIsLooong
approved these changes
Mar 30, 2023
Contributor
LongCatIsLooong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @gspencergoog could you take a look?
gspencergoog
approved these changes
Mar 30, 2023
Contributor
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…#123806) Fix state leak in rendering/editable_test (framework shuffle-all 2/n)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fixes part of #85160. This comes after #123751 as part of removing
no-shuffletags from all tests in the framework.For render objects with the same depth, [paint] gets called in the order that [markNeedsPaint] was called, which is not necessarily the visual paint order. So having a test check the order of [paint] calls is brittle.
Here, it was breaking when an
editable.foregroundPainter = null, intended to clean up a previous test, caused a [markNeedsPaint] on the composite foreground painter before the test could cause a [markNeedsPaint] on the background.Instead, follow the pattern of the neighboring tests and use the
paintsmatcher; remove thepaintHistorystatic field.For debugging this it was useful to have a toString on this test painter class, so add that too.
To be confident there weren't any remaining ordering-related flakes, I ran this test file with both the previously-failing seed in the comment and 308 other seeds, all of which passed. There are only 45 tests in this file, so an ordering-dependent flake would probably have a rate of at least 1/45 = 2.22% (the probability of a given test coming first, or of coming immediately after another given test), and the data is enough to reject that at p<.001, as well as to reject a 1% flake rate at p<.05.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.