Skip to content

Fix TableRow with no children throws unnamed assertion #123770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Mar 30, 2023
Merged

Fix TableRow with no children throws unnamed assertion #123770

auto-submit merged 4 commits into from
Mar 30, 2023

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Mar 30, 2023

fixes #119541

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 30, 2023
@TahaTesser TahaTesser marked this pull request as ready for review March 30, 2023 12:31
@TahaTesser TahaTesser requested a review from goderbauer March 30, 2023 19:29
goderbauer
goderbauer approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/widgets/table.dart Outdated
Comment on lines 151 to 152
if (children.isNotEmpty) {
if (children.any((TableRow row) => row.children.isEmpty)) {
Copy link
Member

@goderbauer goderbauer Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two ifs could be combined to one, I think.

Copy link
Member Author

@TahaTesser TahaTesser Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea.

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@auto-submit auto-submit bot merged commit be23885 into flutter:master Mar 30, 2023
@TahaTesser TahaTesser deleted the fix_empty_table_row_error_message branch March 30, 2023 22:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
4726205 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
1bb464e 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
9276910 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
aeba4b7 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
d929d09 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
513d883 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
eefde41 
…tter/flutter#123770)
@HansMuller HansMuller mentioned this pull request Mar 31, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
2a96248 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
9a106e6 
…tter/flutter#123770)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
67a84dd 
…tter/flutter#123770)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@TahaTesser @exaby73
Fix TableRow with no children throws unnamed assertion (flutter#123770
8de4d70 
)

Fix `TableRow` with no children throws unnamed assertion
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
9091fd8 
…tter/flutter#123770)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
be23885 Fix TableRow with no children throws unnamed assertion (flu…
bb12603 
…tter/flutter#123770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Empty List for TableRow throws unnamed assertion

2 participants

@TahaTesser @goderbauer