Add Linux implementation of the platform view example #123731

robert-ancell · 2023-03-29T23:29:29Z

No description provided.

flutter-dashboard · 2023-03-29T23:29:32Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

robert-ancell · 2023-03-29T23:38:01Z

robert-ancell · 2023-03-29T23:40:44Z

(The screenshot shows the wrong window title - fixed in the branch).

Hixie · 2023-05-30T22:46:06Z

@robert-ancell Is this still on your radar?

robert-ancell · 2023-05-31T02:42:26Z

Yes, @cbracken please review!

cbracken

lgtm!

Causes the build in flutter/flutter#123731 to fail

robert-ancell · 2023-07-04T04:09:48Z

Build is failing due to:

/b/s/w/ir/cache/clang/bin/clang++ -g  CMakeFiles/platform_view.dir/main.cc.o CMakeFiles/platform_view.dir/my_application.cc.o CMakeFiles/platform_view.dir/flutter/generated_plugin_registrant.cc.o -o intermediates_do_not_run/platform_view -L/b/s/w/ir/x/w/flutter/examples/platform_view/linux/flutter/ephemeral -Wl,-rpath,/b/s/w/ir/x/w/flutter/examples/platform_view/linux/flutter/ephemeral:  -lflutter_linux_gtk  /usr/lib/x86_64-linux-gnu/libgtk-3.so  /usr/lib/x86_64-linux-gnu/libgdk-3.so  /usr/lib/x86_64-linux-gnu/libpangocairo-1.0.so  /usr/lib/x86_64-linux-gnu/libpango-1.0.so  /usr/lib/x86_64-linux-gnu/libharfbuzz.so  /usr/lib/x86_64-linux-gnu/libatk-1.0.so  /usr/lib/x86_64-linux-gnu/libcairo-gobject.so  /usr/lib/x86_64-linux-gnu/libcairo.so  /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so  /usr/lib/x86_64-linux-gnu/libgio-2.0.so  /usr/lib/x86_64-linux-gnu/libgobject-2.0.so  /usr/lib/x86_64-linux-gnu/libglib-2.0.so && :
ld.lld: error: undefined symbol: fl_method_call_get_type
>>> referenced by fl_method_call.h:19 (/b/s/w/ir/x/w/flutter/examples/platform_view/linux/flutter/ephemeral/flutter_linux/fl_method_call.h:19)
>>>               CMakeFiles/platform_view.dir/my_application.cc.o:(FL_METHOD_CALL(void*))
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)

For some reason the compiler must be optimizing this away, so I've made flutter/engine#43394 to ensure this symbol is exported. Other get_type() functions already have this change.

robert-ancell · 2023-07-10T20:00:23Z

The build fix has landed in the engine, will rebuild this PR once that engine is being used by Flutter.

robert-ancell · 2023-07-10T23:58:04Z

@gspencergoog is the Google testing failure an issue?

gspencergoog · 2023-07-11T00:06:16Z

It is broken, but I think it's an error from a previous PR in the queue: it doesn't look related to this PR at all. I'd try rebasing to HEAD and see if you can move to a state that builds.

[I'm not sure why you're the one that has bad luck here: this doesn't happen that often, I promise!]

…r/flutter#123731)

Roll Flutter from 3ec96a8 to 544d30d (66 revisions) flutter/flutter@3ec96a8...544d30d 2023-07-12 [email protected] Roll Packages from 188a846 to 2508714 (14 revisions) (flutter/flutter#130418) 2023-07-12 [email protected] Update `RadioListTile` tests format for M2/M3 (flutter/flutter#130391) 2023-07-12 [email protected] Roll Flutter Engine from d68ea304eeda to 5c887028810d (2 revisions) (flutter/flutter#130413) 2023-07-12 [email protected] Roll Flutter Engine from c7317a58466e to d68ea304eeda (1 revision) (flutter/flutter#130410) 2023-07-12 [email protected] Roll Flutter Engine from 3dbe7dbeb5d4 to c7317a58466e (1 revision) (flutter/flutter#130402) 2023-07-12 [email protected] Roll Flutter Engine from 73093fdd77c3 to 3dbe7dbeb5d4 (1 revision) (flutter/flutter#130399) 2023-07-12 [email protected] Roll Flutter Engine from 29c5c41eeb19 to 73093fdd77c3 (2 revisions) (flutter/flutter#130398) 2023-07-12 [email protected] Roll Flutter Engine from 3482e05776a7 to 29c5c41eeb19 (1 revision) (flutter/flutter#130393) 2023-07-12 [email protected] Roll Flutter Engine from 7de68c62742d to 3482e05776a7 (2 revisions) (flutter/flutter#130390) 2023-07-12 [email protected] Make new issue template for 1P package (flutter/flutter#130065) 2023-07-12 [email protected] Roll Flutter Engine from 1b44d7ee1a60 to 7de68c62742d (4 revisions) (flutter/flutter#130384) 2023-07-12 [email protected] Roll Flutter Engine from e109a3c0c347 to 1b44d7ee1a60 (3 revisions) (flutter/flutter#130380) 2023-07-12 [email protected] Roll Flutter Engine from d00590fde18c to e109a3c0c347 (1 revision) (flutter/flutter#130371) 2023-07-12 [email protected] Roll Flutter Engine from 875d87e02276 to d00590fde18c (5 revisions) (flutter/flutter#130369) 2023-07-12 [email protected] Enable not GCed leak tracking. (flutter/flutter#130159) 2023-07-11 [email protected] Roll Flutter Engine from e2df01610fb3 to 875d87e02276 (3 revisions) (flutter/flutter#130359) 2023-07-11 [email protected] autocomplete: Remove mistaken paragraph in `onSelected` doc (flutter/flutter#130190) 2023-07-11 [email protected] Roll Flutter Engine from 59f234645dd2 to e2df01610fb3 (3 revisions) (flutter/flutter#130357) 2023-07-11 [email protected] Refactor refresh_indicator.1.dart to not use shrinkwrap (flutter/flutter#129377) 2023-07-11 [email protected] Links in `material` library docs are outdated (flutter/flutter#129891) 2023-07-11 [email protected] Roll Flutter Engine from afee1db31e5e to 59f234645dd2 (2 revisions) (flutter/flutter#130352) 2023-07-11 [email protected] Roll Flutter Engine from 75ada1bdf9fd to afee1db31e5e (1 revision) (flutter/flutter#130349) 2023-07-11 [email protected] Upgrade leak_tracker to 7.0.6. (flutter/flutter#130346) 2023-07-11 [email protected] Roll Flutter Engine from 0011db79d41f to 75ada1bdf9fd (2 revisions) (flutter/flutter#130345) 2023-07-11 [email protected] Roll pub packages (flutter/flutter#130289) 2023-07-11 [email protected] `DropdownMenu` can be expanded to its parent size (flutter/flutter#129753) 2023-07-11 [email protected] Roll Packages from 4469c5e to 188a846 (6 revisions) (flutter/flutter#130340) 2023-07-11 [email protected] Roll Flutter Engine from d75c70870f86 to 0011db79d41f (2 revisions) (flutter/flutter#130337) 2023-07-11 [email protected] Roll Flutter Engine from 5e9f0d61a42a to d75c70870f86 (1 revision) (flutter/flutter#130332) 2023-07-11 [email protected] Roll Flutter Engine from 417c50199e14 to 5e9f0d61a42a (1 revision) (flutter/flutter#130330) 2023-07-11 [email protected] Roll Flutter Engine from bfda8f173fea to 417c50199e14 (2 revisions) (flutter/flutter#130324) 2023-07-11 [email protected] Add `Badge` widget to `NavigationBar` and `NavigationRail` examples (flutter/flutter#129834) 2023-07-11 [email protected] Roll Flutter Engine from 2139c8a90822 to bfda8f173fea (2 revisions) (flutter/flutter#130321) 2023-07-11 [email protected] Update labeler for recent changes (flutter/flutter#130168) 2023-07-11 [email protected] fix: `ExpansionTileTheme.shape` assignment in `ExpansionTile` (flutter/flutter#127749) 2023-07-11 [email protected] Roll Flutter Engine from 12aa98177cf2 to 2139c8a90822 (2 revisions) (flutter/flutter#130316) 2023-07-11 [email protected] Roll Flutter Engine from 767f2fb8ab03 to 12aa98177cf2 (1 revision) (flutter/flutter#130315) 2023-07-11 [email protected] Implement preferPaintInterior correctly for _CompoundBorder (flutter/flutter#129851) 2023-07-11 [email protected] Roll Flutter Engine from 153d9e1d598a to 767f2fb8ab03 (1 revision) (flutter/flutter#130313) 2023-07-11 [email protected] Roll Flutter Engine from 2c82dd7ec54b to 153d9e1d598a (2 revisions) (flutter/flutter#130311) 2023-07-11 [email protected] Roll Flutter Engine from 312e4813a880 to 2c82dd7ec54b (1 revision) (flutter/flutter#130309) 2023-07-11 [email protected] Roll Flutter Engine from 95316fbc25a7 to 312e4813a880 (2 revisions) (flutter/flutter#130307) 2023-07-11 [email protected] Add Linux implementation of the platform view example (flutter/flutter#123731) 2023-07-11 [email protected] Roll Flutter Engine from daecd616f5a7 to 95316fbc25a7 (4 revisions) (flutter/flutter#130305) 2023-07-11 [email protected] Roll Flutter Engine from 2a0dd9d2f28e to daecd616f5a7 (3 revisions) (flutter/flutter#130298) 2023-07-10 [email protected] Roll Flutter Engine from 7d054abf842c to 2a0dd9d2f28e (4 revisions) (flutter/flutter#130296) ...

flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 29, 2023

robert-ancell requested a review from cbracken March 29, 2023 23:29

robert-ancell force-pushed the linux-platform-view-example branch from 6d9d42e to 8c5585a Compare March 29, 2023 23:40

robert-ancell force-pushed the linux-platform-view-example branch 2 times, most recently from f053dda to 234c181 Compare March 30, 2023 22:36

robert-ancell force-pushed the linux-platform-view-example branch from 234c181 to 8f11f9b Compare May 31, 2023 02:41

github-actions bot removed the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 31, 2023

goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 1, 2023

cbracken approved these changes Jun 16, 2023

View reviewed changes

robert-ancell force-pushed the linux-platform-view-example branch from 8f11f9b to e965620 Compare July 3, 2023 03:08

robert-ancell added a commit to robert-ancell/flutter-engine that referenced this pull request Jul 4, 2023

Stop fl_method_call_get_type() not being exported.

1c5763c

Causes the build in flutter/flutter#123731 to fail

robert-ancell mentioned this pull request Jul 4, 2023

Stop fl_method_call_get_type() not being exported. flutter/engine#43394

Closed

robert-ancell mentioned this pull request Jul 4, 2023

Use better method of ensuring that *_get_type() functions are exported flutter/engine#43395

Merged

robert-ancell force-pushed the linux-platform-view-example branch from e965620 to 863ee44 Compare July 10, 2023 23:13

Add Linux implementation of the platform view example

105ca3c

robert-ancell force-pushed the linux-platform-view-example branch from 863ee44 to 105ca3c Compare July 11, 2023 00:47

robert-ancell merged commit 8ee019d into flutter:master Jul 11, 2023

robert-ancell deleted the linux-platform-view-example branch July 11, 2023 03:45

engine-flutter-autoroll mentioned this pull request Jul 12, 2023

Roll Flutter from 3ec96a8a4a5d to 21e3bb89676c (65 revisions) flutter/packages#4447

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023

8ee019d Add Linux implementation of the platform view example (flutte…

9d600d8

…r/flutter#123731)

engine-flutter-autoroll mentioned this pull request Jul 12, 2023

Roll Flutter from 3ec96a8a4a5d to 544d30dbaddf (66 revisions) flutter/packages#4448

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023

8ee019d Add Linux implementation of the platform view example (flutte…

4cd601a

…r/flutter#123731)

HansMuller mentioned this pull request Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Closed

gbtb16 pushed a commit to gbtb16/flutter that referenced this pull request Nov 6, 2023

Add Linux implementation of the platform view example (flutter#123731)

491545d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Linux implementation of the platform view example #123731

Add Linux implementation of the platform view example #123731

Uh oh!

robert-ancell commented Mar 29, 2023

Uh oh!

flutter-dashboard bot commented Mar 29, 2023

Uh oh!

robert-ancell commented Mar 29, 2023

Uh oh!

robert-ancell commented Mar 29, 2023

Uh oh!

Hixie commented May 30, 2023

Uh oh!

robert-ancell commented May 31, 2023

Uh oh!

cbracken left a comment

Uh oh!

robert-ancell commented Jul 4, 2023

Uh oh!

robert-ancell commented Jul 10, 2023

Uh oh!

robert-ancell commented Jul 10, 2023

Uh oh!

gspencergoog commented Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add Linux implementation of the platform view example #123731

Add Linux implementation of the platform view example #123731

Uh oh!

Conversation

robert-ancell commented Mar 29, 2023

Uh oh!

flutter-dashboard bot commented Mar 29, 2023

Uh oh!

robert-ancell commented Mar 29, 2023

Uh oh!

robert-ancell commented Mar 29, 2023

Uh oh!

Hixie commented May 30, 2023

Uh oh!

robert-ancell commented May 31, 2023

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

robert-ancell commented Jul 4, 2023

Uh oh!

robert-ancell commented Jul 10, 2023

Uh oh!

robert-ancell commented Jul 10, 2023

Uh oh!

gspencergoog commented Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants