Skip to content

Remove the networked image from the example for FittedBox #123728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Mar 30, 2023
Merged

Remove the networked image from the example for FittedBox #123728

zanderso merged 1 commit into from
Mar 30, 2023

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Mar 29, 2023 •
edited
Loading

Description

This removes the Image.network from the example, since that causes a race condition in the test, and an image isn't necessary for the example, it works just was well (maybe better) with a Placeholder widget that shows how the fitted box affects the layout.

Related

Tests

  • No change to the tests because the example test doesn't cover the content of the widget drawn.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 29, 2023
@gspencergoog gspencergoog requested a review from TahaTesser March 29, 2023 22:20
@gspencergoog gspencergoog changed the title Remove the networked image from the example Remove the networked image from the example for FittedBox Mar 29, 2023
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@zanderso
Copy link
Member

zanderso commented Mar 30, 2023

@CaseyHillers here's another instance of g3 testing being blocked on a failing but ignored target.

Landing manually to unblock the Dart -> Engine roll.

@zanderso zanderso merged commit c26d1de into flutter:master Mar 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
60ecd1f 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
a8dd742 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
45f6e4f 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
5d80dc0 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
8323b61 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
1ac9dee 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
6af1e6a 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
af11430 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
fd3df0c 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
ea63d81 
…123728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
3575356 
…123728)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
b2f2f16 
…123728)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
1670076 
…123728)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
7cc7c9e 
…123728)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
c22662e 
…123728)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
c7a1b69 
…123728)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@gspencergoog @exaby73
Remove the networked image from the example (flutter#123728)
0da7773
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
213b74d 
…123728)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c26d1de Remove the networked image from the example (flutter/flutter#…
bfdeff9 
…123728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@TahaTesser TahaTesser Awaiting requested review from TahaTesser

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gspencergoog @zanderso @jason-simmons