Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 29, 2023

@annagrin says web tests should work on arm64 bots. #120014 (comment)

Fixes #120014

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Mar 29, 2023
@jmagman jmagman marked this pull request as ready for review March 29, 2023 22:44
@jmagman jmagman requested a review from annagrin March 29, 2023 22:44
@annagrin
Copy link
Contributor

@annagrin says web tests should work on arm64 bots. #120014 (comment)

I do! If they don't that would be a new issue. I'll monitor this for any failures (and flutter issues). Also please feel free to ping me about web tools tests if anything goes wrong.

@jmagman jmagman added platform-web Web applications specifically autosubmit Merge PR when tree becomes green via auto submit App labels Apr 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 3, 2023

auto label is removed for flutter/flutter, pr: 123714, due to This PR has not met approval requirements for merging. You have project association MEMBER and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 3, 2023

auto label is removed for flutter/flutter, pr: 123714, due to Validations Fail.

@jmagman
Copy link
Member Author

jmagman commented Apr 3, 2023

@annagrin can you give this an official review approval so I can merge?

@jmagman jmagman requested a review from eyebrowsoffire April 3, 2023 23:32
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman jmagman added team-infra Owned by Infrastructure team autosubmit Merge PR when tree becomes green via auto submit App labels Apr 4, 2023
@auto-submit auto-submit bot merged commit f115e28 into flutter:master Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
Run web integration tests on x64 or arm Macs
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Web applications specifically team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

High flake rate on web hot reload test flutter_tools/test/web.shard/hot_reload_web_test.dart on arm64 Macs

3 participants