Skip to content

Modify flutter_tests dart:io mocks to support Dart 3.0 #123706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 30, 2023
Merged

Modify flutter_tests dart:io mocks to support Dart 3.0 #123706

auto-submit merged 3 commits into from
Mar 30, 2023

Conversation

@brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Mar 29, 2023 •
edited
Loading

Changes some dart:io subclasses from extends to implements to be forwards-compatible with dart:io classes that will become interfaces in Dart 3.

See #123711

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 29, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 29, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@brianquinlan brianquinlan marked this pull request as draft March 29, 2023 17:18
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 29, 2023
@Hixie
Copy link
Contributor

Hixie commented Mar 29, 2023

test-exempt: code refactor with no semantic change

@brianquinlan brianquinlan marked this pull request as ready for review March 30, 2023 00:33
jonahwilliams
jonahwilliams approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@auto-submit auto-submit bot merged commit 06f015a into flutter:master Mar 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
8f3e8b8 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
3294756 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
4ee33ec 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
008fde7 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
5118650 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
184885c 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
1e760d8 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
741a131 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
f96b1c2 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
44dab40 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
9b60766 
…er/flutter#123706)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
b997061 
…er/flutter#123706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
8e266d9 
…er/flutter#123706)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
58d1342 
…er/flutter#123706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
fec6749 
…er/flutter#123706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
dba918d 
…er/flutter#123706)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@brianquinlan @exaby73
Modify flutter_tests dart:io mocks to support Dart 3.0 (flutter#123706)
721d95b 
Modify flutter_tests dart:io mocks to support Dart 3.0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
14f4f60 
…er/flutter#123706)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
06f015a Modify flutter_tests dart:io mocks to support Dart 3.0 (flutt…
53814a8 
…er/flutter#123706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jonahwilliams jonahwilliams

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianquinlan @Hixie @jonahwilliams