Skip to content

Serve DevTools when running flutter test #123607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bkonyi merged 4 commits into from
Mar 30, 2023
Merged

Serve DevTools when running flutter test #123607

bkonyi merged 4 commits into from
Mar 30, 2023

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Mar 28, 2023

Also clean up messaging output by flutter test when --start-paused is provided.

@bkonyi
Serve DevTools when running flutter test
d8adf32 
Also clean up messaging output by `flutter test` when `--start-paused`
is provided.
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 28, 2023
@bkonyi
Copy link
Contributor Author

bkonyi commented Mar 28, 2023

I ran a search for any tests relying on the output of flutter test --start-paused and couldn't find any in g3, so the output by this command should be safe to change.

kenzieschmoll
kenzieschmoll reviewed Mar 28, 2023
View reviewed changes
kenzieschmoll
kenzieschmoll approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment regarding what we are printing to console in the null case, but lgtm from DevTools perspective.

@bkonyi bkonyi requested a review from zanderso March 28, 2023 17:10
zanderso
zanderso reviewed Mar 28, 2023
View reviewed changes
packages/flutter_tools/lib/src/test/flutter_tester_device.dart
);
}

Future<void> _startDevTools(Uri forwardingUri, DartDevelopmentService? dds) async {
Copy link
Member

@zanderso zanderso Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have code similar to this anywhere else in the tool?

Copy link
Contributor Author

@bkonyi bkonyi Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have code that's tightly coupled to ResidentRunner in the form of ResidentDevtoolsHandler. I pulled the relevant code out for use here since flutter test doesn't require any of the functionality from ResidentDevtoolsHandler.

@bkonyi
Copy link
Contributor Author

bkonyi commented Mar 30, 2023

@zanderso can we land this?

@bkonyi bkonyi merged commit c3de901 into master Mar 30, 2023
@bkonyi bkonyi deleted the flutter_test_devtools branch March 30, 2023 15:51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
a92def4 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
5b12d82 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
a54afb5 
)
zanderso added a commit that referenced this pull request Mar 30, 2023
@zanderso
Revert "Serve DevTools when running flutter test (#123607)"
388860d 
This reverts commit c3de901.
@zanderso zanderso mentioned this pull request Mar 30, 2023
Merged
zanderso added a commit that referenced this pull request Mar 30, 2023
@zanderso
Revert "Serve DevTools when running flutter test (#123607)" (#123810)
f5bce71 
This reverts commit c3de901.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
49ccca6 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
81eb15b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
1b2e449 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
fa416fe 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
1d0b995 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
3c66b2b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
b8dd3d9 
)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
ddfaba9 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
42bd9cc 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
386fe5b 
)
bkonyi added a commit that referenced this pull request Apr 3, 2023
@bkonyi
Reland "Serve DevTools when running flutter test (#123607)"
9de087d 
Originally reverted due to a misattributed hot reload benchmark
regression.

This reverts commit f5bce71.
bkonyi added a commit that referenced this pull request Apr 4, 2023
@bkonyi
Reland "Serve DevTools when running flutter test (#123607)" (#124058)
d83c510 
Originally reverted due to a misattributed hot reload benchmark
regression.

This reverts commit f5bce71.
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@bkonyi @exaby73
Serve DevTools when running flutter test (flutter#123607)
4d171f9 
Also clean up messaging output by `flutter test` when `--start-paused` is provided.
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@zanderso @exaby73
Revert "Serve DevTools when running flutter test (flutter#123607)" (f…
754157d 
…lutter#123810)

This reverts commit c3de901.
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@bkonyi @exaby73
Reland "Serve DevTools when running flutter test (flutter#123607)" (f…
e61ac1b 
…lutter#124058)

Originally reverted due to a misattributed hot reload benchmark
regression.

This reverts commit f5bce71.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
2493af0 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c3de901 Serve DevTools when running flutter test (flutter/flutter#123607
611ea58 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkonyi @zanderso @kenzieschmoll