Skip to content

Fix off-screen selected text throws exception #123595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 29, 2023
Merged

Fix off-screen selected text throws exception #123595

auto-submit merged 1 commit into from
Mar 29, 2023

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Mar 28, 2023

fixes #123527

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Mar 28, 2023
@TahaTesser TahaTesser marked this pull request as ready for review March 28, 2023 14:20
@TahaTesser TahaTesser requested a review from justinmc March 28, 2023 14:20
justinmc
justinmc approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you for fixing this! I saw @mkobuolys posted on Twitter about it.

packages/flutter/test/widgets/selectable_text_test.dart
await tester.pumpAndSettle();

expect(tester.takeException(), isNull);
});
Copy link
Contributor

@justinmc justinmc Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great test, thanks for fully reproducing the issue 👍

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit auto-submit bot merged commit d74a1bb into flutter:master Mar 29, 2023
@TahaTesser TahaTesser deleted the fix_text_selection_toolbar_anchor branch March 29, 2023 06:55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
8b9bbad 
…r#123595)
@HansMuller HansMuller mentioned this pull request Mar 29, 2023
Merged
8 tasks
@HansMuller
Copy link
Contributor

HansMuller commented Mar 29, 2023 •
edited
Loading

@TahaTesser - this PR is starting to fail a customer test, see #123293 (comment), https://flutter-dashboard.appspot.com/#/build

@HansMuller
Copy link
Contributor

HansMuller commented Mar 29, 2023

It looks like the problem was with the customer test. See #123669, and flutter/tests#241

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
04252ef 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
44b239f 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
c5fae85 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
b117d58 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
08a09f2 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
9ac6a4c 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
788aa38 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
b61124e 
…r#123595)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
768c62a 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
c8cdcda 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
ea5c3ef 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
be074e3 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
eab4826 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
f36ab05 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
334a1b4 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
4161bbf 
…r#123595)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
459c124 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
5c7cb50 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
e95c695 
…r#123595)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
b98620e 
…r#123595)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d74a1bb Fix off-screen selected text throws exception (flutter/flutte…
3f10413 
…r#123595)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Navigating with the selected text throws an exception when selected text is out of view

3 participants

@TahaTesser @HansMuller @justinmc